Proprietary compontents: Google VR SDK

[IzzySoft]

My library scanner just detected com.google.vr in the APK provided at releases here, which is a proprietary compontent: Google VR SDK. Relevant lines in the code should be these:

sdk-videowidget = { module = "com.google.vr:sdk-videowidget", version.ref = "sdkVideowidget" }
sdk-panowidget = { module = "com.google.vr:sdk-panowidget", version.ref = "sdkPanowidget" }

I had hence to apply the NonFreeComp (non-free/proprietary compontents) to your app in my repo. Can there anything be done to avoid that? Thanks in advance!

[naveensingh]

@IzzySoft thanks for pointing this out.

Unfortunately, I haven't found any simple alternatives to those libraries. We probably have to remove them anyway because of GPL.

[Aga-C]

@naveensingh Maybe we could use this for panoramic photos: https://github.com/hannesa2/panoramaGL.

[IzzySoft]

Until you found a replacement, maybe an iterim work-around would be having two different build flavors (e.g. foss and full), removing the two from the foss flavor?

[inson1]

@naveensingh Why it was added? And why tibbi version didnt have it?

[Aga-C]

@inson1 Tibor's version also had it: https://github.com/SimpleMobileTools/Simple-Gallery/blob/3cb12cc41bb579dabb676f2fe83b53a63089fe1b/app/build.gradle.kts#L110C35-L110C35.

[inson1]

@Aga-C so it was even in foss flavor? It seems like it. F-droid didnt mind it? I cant see any anti-feature.

[Aga-C]

@inson1 Yes, looks like they missed it.

[inson1]

@Aga-C thanks

[naveensingh]

@Aga-C so it was even in foss flavor? It seems like it. F-droid didnt mind it? I cant see any anti-feature.

Yes. We haven't added any libraries or features to the apps since they were forked. These libraries were deprecated by Google but never open-sourced (AFAIK). They are used to display panoramic photos/videos. They are harmless on their own and most people don't care about it but we probably have to remove them because of GPL (@12people what do you think?)

@naveensingh Maybe we could use this for panoramic photos: https://github.com/hannesa2/panoramaGL.

@Aga-C I'll check that, thanks. For now, I think I'll remove these libraries completely and later we'll add support for panoramic stuff using some other FOSS lib.