fix: adapt Azure Service Bus MessageBus to two-phase dispose lifecycle#77
Merged
Conversation
- Add ShutdownAsync override for StopProcessingAsync - Add CleanupAsync override for processor/sender/client disposal - Handle OperationCanceledException in OnMessageAsync - Remove ad-hoc Dispose/DisposeAsync - Depends on FoundatioFx/Foundatio#492
Merged
3 tasks
![github-code-quality[bot]](https://avatars.githubusercontent.com/u/9919?s=60&v=4){kind=small}
There was a problem hiding this comment.
Pull request overview
Adapts AzureServiceBusMessageBus to Foundatio’s new two-phase disposal lifecycle (shutdown/drain first, then cleanup), and updates the Azure Service Bus test suite to exercise the new async dispose semantics.
Changes:
- Replace ad-hoc
Dispose/DisposeAsync+ private cleanup helpers withShutdownAsync(drain) andCleanupAsync(dispose resources). - Update message handling to catch
OperationCanceledExceptionduring dispose. - Extend/adjust Azure Service Bus message bus tests to cover new dispose behaviors.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| tests/Foundatio.AzureServiceBus.Tests/Messaging/AzureServiceBusMessageBusTests.cs | Updates/extends base test overrides to validate async dispose lifecycle behavior for the ASB bus. |
| src/Foundatio.AzureServiceBus/Messaging/AzureServiceBusMessageBus.cs | Implements two-phase dispose (ShutdownAsync + CleanupAsync) and tweaks message processing error handling during disposal. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
niemyjski
force-pushed
the
fix/messagebus-subscription-lifecycle
branch
from
4ea90ee to
ed06a7d
Compare
…nAsync, add pre-lock null check
There was a problem hiding this comment.
Pull request overview
This PR updates the Azure Service Bus message bus implementation to align with Foundatio’s new two-phase dispose lifecycle (graceful shutdown/drain followed by resource cleanup), and updates tests/packages accordingly.
Changes:
- Refactors
AzureServiceBusMessageBuscleanup to use lifecycle overrides instead of ad-hocDispose/DisposeAsyncimplementations. - Adjusts message handling during disposal by rethrowing
OperationCanceledException(to avoid message auto-complete). - Updates Foundatio/Foundatio.TestHarness package references and refreshes test coverage around disposal behaviors.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
src/Foundatio.AzureServiceBus/Messaging/AzureServiceBusMessageBus.cs |
Moves disposal logic into lifecycle overrides and tweaks cancellation behavior in message processing. |
src/Foundatio.AzureServiceBus/Foundatio.AzureServiceBus.csproj |
Bumps Foundatio dependency to 13.0.0-beta5.2. |
tests/Directory.Build.props |
Bumps Foundatio.TestHarness dependency to 13.0.0-beta5.2. |
tests/Foundatio.AzureServiceBus.Tests/Messaging/AzureServiceBusMessageBusTests.cs |
Updates/expands test overrides to match new disposal lifecycle expectations. |
samples/Foundatio.AzureServiceBus.Subscribe/Program.cs |
Minor formatting change in catch block. |
samples/Foundatio.AzureServiceBus.Dequeue/Program.cs |
Minor formatting change in catch block. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| return; | ||
| using (await _lock.LockAsync().AnyContext()) | ||
| { | ||
| if (_subscriptionProcessor is not null) |
| { | ||
| using (await _lock.LockAsync().AnyContext()) | ||
| { | ||
| if (_topicSender is not null) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Dependencies
Test plan