Fix build workflow publishing empty.nupkg from EmptyFiles test package#428
Merged
Conversation
|
|
…acts directory Co-authored-by: ejsmith <282584+ejsmith@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix shared build publishing empty.nupkg issue
Fix build workflow publishing empty.nupkg from EmptyFiles test package
Dec 10, 2025
ejsmith
reviewed
Dec 10, 2025
| if: github.event_name != 'pull_request' && github.actor != 'dependabot[bot]' | ||
| run: | | ||
| for package in $(find -name "*.nupkg" | grep "minver" -v); do | ||
| for package in $(find artifacts -name "*.nupkg" 2>/dev/null | grep -v "minver"); do |
Contributor
There was a problem hiding this comment.
@copilot I don't like this fix because it is assuming that builds always go to the artifacts folder.
Contributor
Author
There was a problem hiding this comment.
You're right. I've updated the fix to exclude paths containing /EmptyFiles/ instead of limiting to the artifacts directory. This works regardless of where packages are built. Changes in e3c7182.
Co-authored-by: ejsmith <282584+ejsmith@users.noreply.github.com>
Co-authored-by: ejsmith <282584+ejsmith@users.noreply.github.com>
ejsmith
approved these changes
Dec 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The build workflow was attempting to publish
empty.nupkgcreated by the EmptyFiles test helper package, causing conflicts athttps://nuget.pkg.github.com/foundatiofxandhttps://f.feedz.io/foundatio/foundatio/nuget.Changes
/EmptyFiles/directoryBefore:
After:
This approach excludes test helper files in
tests/**/bin/**/EmptyFiles/while working with any build directory structure, not assuming packages are only in a specific location.Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.