Add poison message handling for queue deserialization failures#455
Merged
Conversation
When a message fails to deserialize during dequeue, it is now abandoned through the normal retry flow instead of crashing the consumer. This gives operators a window to fix transient serializer issues before messages are permanently dead-lettered. - Add FaultInjectingSerializer test infrastructure for simulating failures - Add DequeueAsync_WithPoisonMessage_MovesToDeadletterAsync base test - Add EnqueueAsync_WithSerializationError_ThrowsAndLeavesQueueEmptyAsync base test - Make QueueEntry null-safe for poison message entries with null values - Add ISerializer parameter to GetQueue for test serializer injection - Document poison message handling flow in queues guide - Remove #region directives from InMemoryQueueTests Co-authored-by: Cursor <cursoragent@cursor.com>
This was referenced Apr 21, 2026
This was referenced May 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Poison Message Flow
Dequeue -> Deserialize fails -> Abandon (attempt incremented) -> Still has retries? -> Re-queued with backoff delay -> Retries exhausted? -> Moved to dead letter queue
Changes
Provider implementations (separate repos)
Each provider repo has corresponding changes to wire up the poison message handling in their DequeueImplAsync:
Test plan
Made with Cursor