sync fast cloner to 3.5.3#485
Conversation
|
@niemyjski I believe the failing test here on the provisioned runner is unrelated to the cloning.
|
|
@niemyjski looked into the failing thing out of curiosity in 4744fc1 - xunit creates a new test class instance of |
|
Thank you, I'll take a look into it. Was just deep diving into how I can make those meters better as it's kind of sync/async problem too. Also I wanted to log an issue for this as well but I noticed when I run dotnet format on the project it formats all of these files and I have an active branch open for enabling nullable reference types (dotnet/skills for implementing it was super easy) which resulted in more changes. I'd be happy to open a pr for either but it might be more back and forth than a quick commit. |
This reverts a custom patch added to FastCloner in f199294 and syncs to upstream
v3.5.3. There was indeed a bug inv3.5.2(sorry about that) - but the custom patch here is wrong and could cause bugs. See lofcz/FastCloner@9eb89d3#diff-84e02a68b92cb9aa70d119689ba40fb38eb9165edd0b751e30aa3f93b21d4d8fR261 - the custom patch would fail this test.Verified both test harnesses pass.