Conversation
colin-axner
left a comment
colin-axner
left a comment
There was a problem hiding this comment.
Add functionality of verbose flag and fill in godoc for cli commands
hamdiallam
force-pushed
the
hamdi/verbose
branch
from
ac36269 to
4f58e1f
Compare
Codecov Report
@@ Coverage Diff @@
## develop #181 +/- ##
===========================================
+ Coverage 52.02% 52.16% +0.14%
===========================================
Files 28 28
Lines 1359 1363 +4
===========================================
+ Hits 707 711 +4
Misses 538 538
Partials 114 114
Continue to review full report at Codecov.
|
wesgraham
left a comment
wesgraham
left a comment
There was a problem hiding this comment.
Looks good to me, thanks
| // transaction hash | ||
| txHash, err := hex.DecodeString(utils.RemoveHexPrefix(arg)) | ||
| if err != nil { | ||
| fmt.Printf("Error decoding tx hash hex-encoded string: %s\n", err) |
There was a problem hiding this comment.
What is the reasoning for printing the error as opposed to wrapping it? Also, error messages returned should begin with lowercase.
There was a problem hiding this comment.
that's a good point. Should just return it
| "strings" | ||
| ) | ||
|
|
||
| // IncludeCmd - |
There was a problem hiding this comment.
do you plan to update these godoc's or nah?
There was a problem hiding this comment.
I'll update them. Found a bug in plasmad and paused on the cli work
4 participants
Addresses #162
Add optional persistent verbose flag that can be reused across commands. Not used atm.
Added some godoc