Conversation
|
Renders successfully locally with A couple of things I immediately notice in looking at the site that we may want to fix sooner rather than later:
@slager or @mayerbry any thoughts about these two items? My inclination is to make those changes in this PR (assuming you agree they're a good idea in general), since they're small and easy to knock out now. (But save any changes to documentation of individual functions, etc. for later.) |
|
actually I've only done one PR to VISCfunctions so I'm not sure I need to be listed as a developer (sometimes I mix up what's happened here vs. in VISCtemplates)... but I maintain my opinion that we should add Dave :) |
|
@mayerbry can you review this PR and let us know what you think? |
|
Thinking about @kelliemac 's suggestions a little bit
|
mayerbry
left a comment
There was a problem hiding this comment.
This is great!!
Per our discussion:
- it would be nice if the browser tab started with the package name (package name:title, instead of title:package name) but that maybe that's not trivial
- Update author list
- remove email from former hutch folks
- move current authors to top (me, Dave, Kellie, Gabby, Claudio)
- Ideal: make an "Original Authors" list and move former authors there
- simple (if ideal is a pain): just move original authors to the end of the current list
|
@slager just to be clear I am perfectly happy with you merging this PR with or without incorporating any of the suggestions from me! if it's not straightforward to tackle them now, don't worry about it. it sounds like you and bryan chatted about this too but I don't think this PR needs to be held up on my account. |
Attempt to set up automated github pages website via usethis defaults.
Renders successfully on a local site build with
pkgdown::build_site()Needs to make its way into
mainto be deployed onto the github.io website.