Skip to content

Adding median_quartiles to pairwise_test_cont()#99

Merged
slager merged 13 commits intodevelopfrom
lemireg-add_quartiles-pairwise_test_cont
Feb 18, 2026
Merged

Adding median_quartiles to pairwise_test_cont()#99
slager merged 13 commits intodevelopfrom
lemireg-add_quartiles-pairwise_test_cont

Conversation

@lemireg
Copy link

@lemireg lemireg commented Dec 31, 2024

A number of requests have come in for the testing comparison tables to include Median (25%, 75%) quartiles instead of the current output Median (Min, Max) as a part of the output of pairwise_test_cont() function.

@lemireg lemireg requested review from mayerbry and slager December 31, 2024 22:07
@lemireg
Copy link
Author

lemireg commented Jan 7, 2025

Bryan's comments:

  • you could get away with Group1_q1 instead of Group1_first_quart (and using q1 or q3 elsewhere)
  • you should check in on the type argument for quantile() function and double-check what the standard is for SAS and hvtn. this is something we've run into in the past when trying to sync results. might be ok to keep the default.
  • you might also force names = FALSE
  • makes sure to update the tests too!

@slager
Copy link
Contributor

slager commented Mar 31, 2025

Feel free to re-tag me if/when this needs another review!

@slager slager removed their request for review March 31, 2025 05:29
@lemireg lemireg changed the title Adding median_first_quart_third_quart to pairwise_test_cont() Adding median_quartiles to pairwise_test_cont() Dec 3, 2025
@lemireg lemireg marked this pull request as ready for review December 5, 2025 00:20
@lemireg lemireg requested a review from slager December 5, 2025 00:20
@lemireg
Copy link
Author

lemireg commented Dec 5, 2025

FYI for one of the tests I am simply dropping the column rather than editing the fixed data. We can discuss at our next meeting if this is the preferred approach. I didn't want to change the fixed data and break other things!

@lemireg lemireg removed the request for review from slager January 6, 2026 18:22
@mayerbry
Copy link
Contributor

looks great! revert the two .Rds whitespace changes in the man/folder

@slager
Copy link
Contributor

slager commented Feb 17, 2026

I'm finished making commits here! Please double check all looks as expected prior to merging.

@slager slager merged commit 451efec into develop Feb 18, 2026
7 checks passed
@slager slager deleted the lemireg-add_quartiles-pairwise_test_cont branch February 18, 2026 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants