Add @snowpack/plugin-react-refresh to React scripts#829
Merged
FredKSchott merged 3 commits intoFredKSchott:masterfrom Aug 17, 2020
Merged
Add @snowpack/plugin-react-refresh to React scripts#829FredKSchott merged 3 commits intoFredKSchott:masterfrom
@snowpack/plugin-react-refresh to React scripts#829FredKSchott merged 3 commits intoFredKSchott:masterfrom
Conversation
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/pikapkg/snowpack/hjh9o7f54 |
stramel
requested review from
FredKSchott and
drwpow
and removed request for
drwpow
Contributor
Author
|
Although, in the CRA codebase, they say 16.10 is required. I'm going to update it to that. |
drwpow
approved these changes
Aug 17, 2020
Collaborator
drwpow
left a comment
drwpow
left a comment
There was a problem hiding this comment.
LGTM! I also like the idea of dogfooding this—we test out the React templates a lot so this would help us catch bugs in the react-refresh plugin quicker.
FredKSchott
approved these changes
Aug 17, 2020
Owner
|
@drwpow can you make sure that you test manually before our 2.8 release? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Adds the
@snowpack/plugin-react-refreshplugin back into the React scripts by default. The reasoning behind this is that:It is also, pretty easy for a user to remove this plugin if they don't want to use it.
Added a peer dependency of 16.9.0 to the
@snowpack/plugin-react-refreshsince it requires at least that to run. (facebook/react#16604 (comment))Testing
Tested in the
@snowpack/app-template-reactand@snowpack/app-template-react-typescriptto ensure it was working.