[Feature Request]: Prevent options being passed to external player's command

[mooreye]

Guidelines

• I have searched the issue tracker for open and closed issues that are similar to the feature request I want to file, without success.
• I have searched the documentation for information that matches the description of the feature request I want to file, without success.
• This issue contains only one feature request.

Problem Description

Currently Freetube passes options like --speed=… or --start=… to external player (mpv in this case). It would be nice to have the ability to ignore them and just pass the video URL.

Proposed Solution

I currently use the following wrapper script to mpv to achieve this, and point external player in settings to it:

#!/usr/bin/bash

set -e
set -uo pipefail

# mpv with non-option arguments only (workaround to ignore playback-affecting options)
literal=0
arguments=()
for arg in "$@"; do
    if [[ $literal == 1 ]]; then
        arguments+=("$arg")
    elif [[ $arg == -- ]]; then
        literal=1
    elif [[ $arg =~ ^- ]]; then
        :
    else
        arguments+=("$arg")
    fi
done

exec mpv "${arguments[@]}"

Alternatives Considered

none

Issue Labels

improvement to existing feature

Additional Information

No response

[efb4f5ff-1298-471a-8973-3d47447115dc]

Summoning @trostboot

[trostboot]

Well, for starters, start offsets shouldn't be passed unless you have some saved watch progress in Freetube itself. If there is no saved progress and you're still seeing --start being passed, then that shouldn't happen.

On to the main point, @mooreye do I understand this correctly, you want a simple toggle to disable the passing of any additional arguments besides the video URL (playback rate, progress, playlist URL, shuffle, loop, reverse, all depending on the individual player) regardless of whether there would be valid, non-default values in them?

[mooreye]

Well, for starters, start offsets shouldn't be passed unless you have some saved watch progress in Freetube itself. If there is no saved progress and you're still seeing --start being passed, then that shouldn't happen.

On to the main point, @mooreye do I understand this correctly, you want a simple toggle to disable the passing of any additional arguments besides the video URL (playback rate, progress, playlist URL, shuffle, loop, reverse, all depending on the individual player) regardless of whether there would be valid, non-default values in them?

yes I want a simple toggle.

[trostboot]

@mooreye Please test #4515, a build of the PR can be found here.

[mooreye]

@mooreye Please test #4515, a build of the PR can be found here.

I tried the appimage version, seems good