[Bug]: Videos always start automatically ignoring settings since shaka-player updated to 4.13.0

[Gorrrg]

Guidelines

• I have encountered this bug in the latest release of FreeTube.
• I have encountered this bug in the official downloads of FreeTube.
• I have searched the issue tracker for open and closed issues that are similar to the bug report I want to file, without success.
• I have searched the documentation for information that matches the description of the bug I want to file, without success.
• This issue contains only one bug.

Describe the bug

1. Go to Settings->Player turn "Start Videos Automatically" off
2. Open a video
3. The video starts playing automatically

Expected Behavior

When autoplayVideos is set to false and a video is opened it shouldn't start automatically.

Issue Labels

feature stopped working

FreeTube Version

Build 5538

Operating System Version

Windows 11 24H2

Installation Method

.exe

Primary API used

Local API

Last Known Working FreeTube Version (If Any)

Build 5537

Additional Information

No response

Nightly Build

• I have encountered this bug in the latest nightly build.

[EsmailELBoBDev2]

i can confirm, any workaround?

Arch linux, installed via flatpak

I have the same error as well. Arch linux, installed using AUR source files.

Could the problem be with one of the event listeners in AutoplayToggle.js?

[kommunarr]

Possible but unlikely due to that toggle referring to the other type of autoplay (playing the next video versus starting the just-loaded one). First thing to do would be to check in https://shaka-player-demo.appspot.com and manipulating the HTML to disable the autoplay property to see if it's a Shaka issue.

Okay. I'm not too good with vue code, but I wanted to try to help as I enjoy this software.

I saw this in the vue code of the shaka player: "autoplayVideos ? true : null". Is there a possibility that when this is rendered in HTML, the video has the 'autoplay' attribute attached to it?

[kommunarr]

No worries @cedartux, appreciate the looking into it. That variable is different from the one that controls whether the next video is loaded in after the current one (autoplayEnabled, admittedly not the best naming schema). If you set up FreeTube locally in dev mode as per the documentation here, you can see the effect of just setting autoplay="null" directly and seeing what happens. It still doesn't work correctly, which implies that it might be an issue upstream with Shaka.

Okay, I will look into that and check this out. Thanks @kommunarr.

[profucius]

Confirmed issue still exists in today's 0.23.1. Issue not present in 0.22.1, tested via version rollback.

[belenos]

Confirmed issue still exists in today's 0.23.1. Issue not present in 0.22.1, tested via version rollback.

I can confirm that as I also have both versions installed, on Arch Linux. 0.23.1 seems to have fixed the 403 errors, but introduced this autoplay bug. Also, the player's “autoplay is on/off” button does nothing (and seems like redundant UI, once we have the feature disabled in Settings tbh. It should disappear in the player if we toggle it off in Settings)

[ClaudeLib]

0.23.1 seems to have fixed the 403 errors, but introduced this autoplay bug.

It's there since v0.23.