Skip to content

Fix thumbnail being obstructed by time tooltip#2078

Merged
PrestonN merged 2 commits intoFreeTubeApp:developmentfrom
0x6e656b6f:development
Feb 21, 2022
Merged

Fix thumbnail being obstructed by time tooltip#2078
PrestonN merged 2 commits intoFreeTubeApp:developmentfrom
0x6e656b6f:development

Conversation

@0x6e656b6f
Copy link
Contributor


Title

Pull Request Type
Please select what type of pull request this is:

  • Bugfix
  • Feature Implementation

Related issue
Closes #2077

Description
Fixes thumbnail being obstructed by time tooltip by moving the thumbnail up.

Screenshots
Before:
1cceb243add2a516219f6e4859682d77684e3b02194ea7d676bc3d1f392a4a45

After:
87303890f4ab8c7586f74e8a5f35c845c62d74413c868f144b229d0f60e38366

Testing
Has this pull request been tested? Yes
UI scale works fine after the patch.

Desktop:

  • OS: [Fedora Workstation]
  • OS Version: [35]
  • FreeTube version: [16.0 Beta]

@PrestonN PrestonN enabled auto-merge (squash) February 14, 2022 06:16
@efb4f5ff-1298-471a-8973-3d47447115dc efb4f5ff-1298-471a-8973-3d47447115dc added the PR: waiting for review For PRs that are complete, tested, and ready for review label Feb 14, 2022
Copy link
Member

@PikachuEXE PikachuEXE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally but that eliminated space 😬

auto-merge was automatically disabled February 15, 2022 02:45

Head branch was pushed to by a user without write access

Co-authored-by: PikachuEXE <pikachuexe@gmail.com>
@PrestonN PrestonN enabled auto-merge (squash) February 15, 2022 02:46
@0x6e656b6f
Copy link
Contributor Author

0x6e656b6f commented Feb 15, 2022

Thanks for the suggestion, I already applied it. Also sorry for that 😁

@PikachuEXE
Copy link
Member

@efb4f5ff-1298-471a-8973-3d47447115dc

Will review all pr's later today!

@efb4f5ff-1298-471a-8973-3d47447115dc
Copy link
Member

efb4f5ff-1298-471a-8973-3d47447115dc commented Feb 21, 2022

Hmm i dont know whats happening here but i dont see the thumbnail when i try to test this PR but i do see it in the latest nightly build.

edit: nvm already fixed that

@PrestonN PrestonN merged commit 147ebde into FreeTubeApp:development Feb 21, 2022
@efb4f5ff-1298-471a-8973-3d47447115dc efb4f5ff-1298-471a-8973-3d47447115dc removed the PR: waiting for review For PRs that are complete, tested, and ready for review label Apr 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Thumbnail is obstructed by time tooltip

5 participants