Fix/SearchHistoryDuplicate#2124
Merged
PrestonN merged 1 commit intoFreeTubeApp:developmentfrom Mar 26, 2022
hockerschwan:Fix/SearchHistoryDuplicate
Merged
Fix/SearchHistoryDuplicate#2124PrestonN merged 1 commit intoFreeTubeApp:developmentfrom hockerschwan:Fix/SearchHistoryDuplicate
PrestonN merged 1 commit intoFreeTubeApp:developmentfrom
hockerschwan:Fix/SearchHistoryDuplicate
Conversation
payload.data is already concatenated in Search.js
Member
|
Also closes #1659 |
efb4f5ff-1298-471a-8973-3d47447115dc
added
the
PR: waiting for review
efb4f5ff-1298-471a-8973-3d47447115dc
requested changes
Mar 14, 2022
Member
efb4f5ff-1298-471a-8973-3d47447115dc
left a comment
efb4f5ff-1298-471a-8973-3d47447115dc
left a comment
There was a problem hiding this comment.
everything lgtm only have one request
efb4f5ff-1298-471a-8973-3d47447115dc
approved these changes
Mar 14, 2022
PikachuEXE
approved these changes
Mar 26, 2022
efb4f5ff-1298-471a-8973-3d47447115dc
removed
the
PR: waiting for review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Title
Pull Request Type
Please select what type of pull request this is:
Related issue
closes #2123
closes #1659
Description
Fix
addToSessionSearchHistoryin utils.js(
payload.datais already concatenated in Search.js)Screenshots (if appropriate)
First page
No duplicates
Testing (for code that is not small enough to be easily understandable)
Has this pull request been tested?
Please describe shortly how you tested it and whether there are any ramifications remaining.
Desktop (please complete the following information):