Fix: trending cache

[ChunkyProgrammer]

---

Fix: trending cache

Pull Request Type
Please select what type of pull request this is:

• Bugfix
• Feature Implementation

Related issue
None

Description
Trending pages weren't getting cached properly so multiple requests could have been made that weren't wanted/needed when navigating through the trending pages

Testing (for code that is not small enough to be easily understandable)
Has this pull request been tested?
Switch the trending page tabs and see it load properly without logging (invidious and local api use console logging)

Desktop (please complete the following information):

• OS: Windows
• OS Version: 10
• FreeTube version: 0.16.0

[efb4f5ff-1298-471a-8973-3d47447115dc]

This is what i get using the nightly build

renderer.js:2 getting local trending
C:\Users\xxx\Desktop\freetube-0.16.0-nightly-1513-win\resources\app.asar\node_modules\axios\lib\adapters\xhr.js:187 GET https://consent.youtube.com/m?continue=https%3A%2F%2Fwww.youtube.com%2Ffeed%2Ftrending%3Fpersist_gl%3D1%26gl%3DNL%26cbrd%3D1&gl=NL&m=0&pc=yt&uxe=23983171&hl=en&src=1 403
dispatchXhrRequest @ C:\Users\xxx\Desktop\freetube-0.16.0-nightly-1513-win\resources\app.asar\node_modules\axios\lib\adapters\xhr.js:187
xhrAdapter @ C:\Users\xxx\Desktop\freetube-0.16.0-nightly-1513-win\resources\app.asar\node_modules\axios\lib\adapters\xhr.js:13
dispatchRequest @ C:\Users\xxx\Desktop\freetube-0.16.0-nightly-1513-win\resources\app.asar\node_modules\axios\lib\core\dispatchRequest.js:53
request @ C:\Users\xxx\Desktop\freetube-0.16.0-nightly-1513-win\resources\app.asar\node_modules\axios\lib\core\Axios.js:108
Axios.<computed> @ C:\Users\xxx\Desktop\freetube-0.16.0-nightly-1513-win\resources\app.asar\node_modules\axios\lib\core\Axios.js:129
wrap @ C:\Users\xxx\Desktop\freetube-0.16.0-nightly-1513-win\resources\app.asar\node_modules\axios\lib\helpers\bind.js:9
requestTrendingPage @ C:\Users\xxx\Desktop\freetube-0.16.0-nightly-1513-win\resources\app.asar\node_modules\yt-trending-scraper\src\TrendingRequester.js:31
scrape_trending_page @ C:\Users\xxx\Desktop\freetube-0.16.0-nightly-1513-win\resources\app.asar\node_modules\yt-trending-scraper\src\Youtube-Scraper.js:21
getTrendingInfoLocal @ renderer.js:2
getTrendingInfo @ renderer.js:2
changeTab @ renderer.js:2
click @ renderer.js:2
Mt @ renderer.js:2
n @ renderer.js:2
Gi.r._wrapper @ renderer.js:2
renderer.js:2 TypeError: Cannot read properties of undefined (reading 'match')
    at Function.parse_new_html (C:\Users\xxx\Desktop\freetube-0.16.0-nightly-1513-win\resources\app.asar\node_modules\yt-trending-scraper\src\Youtube-Scraper.js:27)
    at Function.scrape_trending_page (C:\Users\xxx\Desktop\freetube-0.16.0-nightly-1513-win\resources\app.asar\node_modules\yt-trending-scraper\src\Youtube-Scraper.js:22)

Doesnt seem to work for me when testing on the PR

1. Trending.js?2db6:120 getting local trending
2. /home/z/FreeTube/node_modules/axios/lib/adapters/xhr.js:187 GET https://consent.youtube.com/m?continue=https%3A%2F%2Fwww.youtube.com%2Ffeed%2Ftrending%3Fpersist_gl%3D1%26gl%3DGB%26cbrd%3D1&gl=NL&m=0&pc=yt&uxe=23983171&hl=en&src=1 403
3. dispatchXhrRequest @ /home/z/FreeTube/node_modules/axios/lib/adapters/xhr.js:187
4. xhrAdapter @ /home/z/FreeTube/node_modules/axios/lib/adapters/xhr.js:13
5. dispatchRequest @ /home/z/FreeTube/node_modules/axios/lib/core/dispatchRequest.js:53
6. request @ /home/z/FreeTube/node_modules/axios/lib/core/Axios.js:108
7. Axios.<computed> @ /home/z/FreeTube/node_modules/axios/lib/core/Axios.js:129
8. wrap @ /home/z/FreeTube/node_modules/axios/lib/helpers/bind.js:9
9. requestTrendingPage @ /home/z/FreeTube/node_modules/yt-trending-scraper/src/TrendingRequester.js:31
10. scrape_trending_page @ /home/z/FreeTube/node_modules/yt-trending-scraper/src/Youtube-Scraper.js:21
11. getTrendingInfoLocal @ Trending.js?2db6:127
12. getTrendingInfo @ Trending.js?2db6:108
13. changeTab @ Trending.js?2db6:98
14. click @ Trending.vue?e4cd:40
15. invokeWithErrorHandling @ vue.common.dev.js?4650:1868
16. invoker @ vue.common.dev.js?4650:2193
17. original._wrapper @ vue.common.dev.js?4650:7587
18. Trending.js?2db6:139 TypeError: Cannot read properties of undefined (reading 'match')
19.    at Function.parse_new_html (/home/z/FreeTube/node_modules/yt-trending-scraper/src/Youtube-Scraper.js:27)
20.    at Function.scrape_trending_page (/home/z/FreeTube/node_modules/yt-trending-scraper/src/Youtube-Scraper.js:22)

[ChunkyProgrammer]

ttps://consent.youtube.com/m?continue=https%3A%2F%2Fwww.youtube.com%2Ffeed%2Ftrending%3Fpersist_gl%3D1%26gl%3DGB%26cbrd%3D1&gl=NL&m=0&pc=yt&uxe=23983171&hl=en&src=1 4

do you get this error when not using this pr?

[efb4f5ff-1298-471a-8973-3d47447115dc]

ttps://consent.youtube.com/m?continue=https%3A%2F%2Fwww.youtube.com%2Ffeed%2Ftrending%3Fpersist_gl%3D1%26gl%3DGB%26cbrd%3D1&gl=NL&m=0&pc=yt&uxe=23983171&hl=en&src=1 4

do you get this error when not using this pr?

updated my previous comment for u to see what i get when using nightly build.

but to answer your question. Yes i do get that.

[efb4f5ff-1298-471a-8973-3d47447115dc]

@ChunkyProgrammer just noticed that this error is because of my VPN location.

It was set to netherlands and i got the error.
After that i set it to France i got the error.
i set my location to USA and didnt get any error

[efb4f5ff-1298-471a-8973-3d47447115dc]

LGTM!

[PrestonN]

LGTM