Skip to content

Fast forward = Playback rate × Interval#2153

Merged
PrestonN merged 1 commit intoFreeTubeApp:developmentfrom
hockerschwan:feature/FastForwardGoesFaster
Mar 30, 2022
Merged

Fast forward = Playback rate × Interval#2153
PrestonN merged 1 commit intoFreeTubeApp:developmentfrom
hockerschwan:feature/FastForwardGoesFaster

Conversation

@hockerschwan
Copy link
Contributor

@hockerschwan hockerschwan commented Mar 27, 2022

Pull Request Type

  • Bugfix
  • Feature Implementation

Related issue
closes #2146

Description

On YT if the playback speed is 2x and fast forward one time, it will fast forward 10sec instead of 5sec.

It also skips less when rate < 1 (same as youtube)

Testing (for code that is not small enough to be easily understandable)
Change playback rate and interval then press J, L Left arrow & Right arrow.

Desktop (please complete the following information):

  • OS: Windows 10
  • OS Version: 21H1
  • FreeTube version: 2bbb875

@PrestonN PrestonN enabled auto-merge (squash) March 27, 2022 07:03
Copy link
Member

@ChunkyProgrammer ChunkyProgrammer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@efb4f5ff-1298-471a-8973-3d47447115dc efb4f5ff-1298-471a-8973-3d47447115dc added the PR: waiting for review For PRs that are complete, tested, and ready for review label Mar 28, 2022
@PrestonN PrestonN merged commit d5c40be into FreeTubeApp:development Mar 30, 2022
@hockerschwan hockerschwan deleted the feature/FastForwardGoesFaster branch March 30, 2022 02:12
@efb4f5ff-1298-471a-8973-3d47447115dc efb4f5ff-1298-471a-8973-3d47447115dc removed the PR: waiting for review For PRs that are complete, tested, and ready for review label Apr 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature Request]: multiply playback speed and fast forward interval time

5 participants