Only fetch the most recent update from the GitHub releases#2169
Merged
PrestonN merged 1 commit intoFreeTubeApp:developmentfrom Apr 8, 2022
Merged
Only fetch the most recent update from the GitHub releases#2169PrestonN merged 1 commit intoFreeTubeApp:developmentfrom
PrestonN merged 1 commit intoFreeTubeApp:developmentfrom
Conversation
efb4f5ff-1298-471a-8973-3d47447115dc
added
the
PR: waiting for review
efb4f5ff-1298-471a-8973-3d47447115dc
approved these changes
Apr 7, 2022
efb4f5ff-1298-471a-8973-3d47447115dc
removed
the
PR: waiting for review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Only fetch the most recent update from the GitHub releases
Important note
We may remove your pull request if you do not use this provided PR template correctly.
Pull Request Type
Please select what type of pull request this is:
Related issue
n/a
Description
Instead of fetching a full page (default 30) releases from the GitHub API when checking for updates, only fetch the first item, this reduces the response from ~50kB to ~4.4kB. This should make checking for updates significantly faster.
Screenshots (if appropriate)
n/a
Testing (for code that is not small enough to be easily understandable)
Has this pull request been tested? Yes
Please describe shortly how you tested it and whether there are any ramifications remaining. No additional errors were logged in the devtools console during the update check, additionally the request was successful in the network tab of the devtools
Desktop (please complete the following information):
Additional context
GitHub releases API docs