Clear watch progress from view cache when removing video form history#2220
Merged
PrestonN merged 1 commit intodevelopmentfrom Apr 27, 2022
Merged
Conversation
Svallinn
requested review from
ChunkyProgrammer,
PikachuEXE,
cloudrac3r and
efb4f5ff-1298-471a-8973-3d47447115dc
PikachuEXE
approved these changes
Apr 25, 2022
efb4f5ff-1298-471a-8973-3d47447115dc
approved these changes
Apr 25, 2022
efb4f5ff-1298-471a-8973-3d47447115dc
added
the
PR: waiting for review
ChunkyProgrammer
approved these changes
Apr 27, 2022
github-actions
bot
removed
the
PR: waiting for review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Type
Description
On the channel view (and pretty much anywhere with a
ft-list-videocomponent), after removing a seen video from history through the context menu, the page would still remember the watch progress and delegate it to the external player afterwards, which was very annoying since most of those videos' previous watch progress is basically at the end of the video.This PR clears that view's cached watch progress value after removing the video from history.
Additional notes
I personally don't care, but I'll leave it here as a note in case someone wants to look into it.
I noticed that the watch progress bar value doesn't always seem to be accurate.
It's possible that the calculation for this value is badly done or the values provided to the calculation itself are a bit off, I don't know ¯\_(ツ)_/¯