Fix channel names being cut off#2292
Merged
PrestonN merged 1 commit intoFreeTubeApp:developmentfrom Jun 21, 2022
Merged
Conversation
efb4f5ff-1298-471a-8973-3d47447115dc
added
the
PR: waiting for review
Member
|
How do I test this ?_? |
Member
|
@vallode could u maybe provide a usecase? |
Contributor
Author
|
@efb4f5ff-1298-471a-8973-3d47447115dc @PikachuEXE provided a test case in the PR description, just go to Whitelight youtube channel and check the featured channels. |
efb4f5ff-1298-471a-8973-3d47447115dc
approved these changes
Jun 20, 2022
Member
efb4f5ff-1298-471a-8973-3d47447115dc
left a comment
efb4f5ff-1298-471a-8973-3d47447115dc
left a comment
There was a problem hiding this comment.
lgtm
absidue
approved these changes
Jun 20, 2022
PikachuEXE
approved these changes
Jun 21, 2022
Member
PikachuEXE
left a comment
PikachuEXE
left a comment
There was a problem hiding this comment.
Locally tested
Now I notice it's fixing the cut off of long channel name
github-actions
bot
removed
the
PR: waiting for review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix channel names being cut off
Pull Request Type
Please select what type of pull request this is:
Related issue
Closes #2291
Description
Adds ellipsis overflow to featured channel names
Testing
Screenshots (if appropriate)
Before:
After:
Desktop (please complete the following information):