Fix download filename problems#2310
Merged
PrestonN merged 2 commits intoFreeTubeApp:v0.17.0-RCfrom Jun 21, 2022
hockerschwan:dl-name-replace
Merged
Fix download filename problems#2310PrestonN merged 2 commits intoFreeTubeApp:v0.17.0-RCfrom hockerschwan:dl-name-replace
PrestonN merged 2 commits intoFreeTubeApp:v0.17.0-RCfrom
hockerschwan:dl-name-replace
Conversation
efb4f5ff-1298-471a-8973-3d47447115dc
added
the
PR: waiting for review
auto-merge was automatically disabled
June 13, 2022 23:12
Head branch was pushed to by a user without write access
auto-merge was automatically disabled
June 13, 2022 23:16
Base branch changed by a user without write access
Member
|
Just to be sure. Ur only addressing nr 2 in this pr right? |
Contributor
Author
|
No2 ( invalid characters dont get replaced...) and No4 ("55).mp4") will be solved by 1.Replace forbidden chars I should have written more detailed descriptions. |
efb4f5ff-1298-471a-8973-3d47447115dc
added
PR: changes requested
PR: waiting for review
efb4f5ff-1298-471a-8973-3d47447115dc
approved these changes
Jun 19, 2022
efb4f5ff-1298-471a-8973-3d47447115dc
requested review from
ChunkyProgrammer,
PikachuEXE and
absidue
absidue
approved these changes
Jun 20, 2022
PikachuEXE
approved these changes
Jun 21, 2022
github-actions
bot
removed
the
PR: waiting for review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Type
Related issue
None
addressed here
Description
downloadFolderPathis not emptyScreenshots (if appropriate)
Testing (for code that is not small enough to be easily understandable)
Desktop (please complete the following information):
Additional context
What characters are forbidden in Windows and Linux directory names?
What characters are forbidden in OS X filenames?