Skip to content

Fix the YouTube GDPR cookie not being sent along with requests#2316

Merged
PrestonN merged 1 commit intoFreeTubeApp:v0.17.0-RCfrom
absidue:fix-gdpr-cookie
Jun 15, 2022
Merged

Fix the YouTube GDPR cookie not being sent along with requests#2316
PrestonN merged 1 commit intoFreeTubeApp:v0.17.0-RCfrom
absidue:fix-gdpr-cookie

Conversation

@absidue
Copy link
Member

@absidue absidue commented Jun 13, 2022


Fix the YouTube GDPR cookie not being sent along with requests

Pull Request Type

  • Bugfix

Description

Fixes the empty GDPR consent cookie not being sent along with requests to YouTube. This fixes the trending tab and the channel community page (#1568) in Europe.

Testing (for code that is not small enough to be easily understandable)
Yes, this change successfully fixed trending and the channel community page in Europe.

Desktop (please complete the following information):

  • OS: Windows
  • OS Version: 10
  • FreeTube version: v0.17.0-RC

@absidue absidue added the PR: waiting for review For PRs that are complete, tested, and ready for review label Jun 13, 2022
@PrestonN PrestonN enabled auto-merge (squash) June 13, 2022 15:14
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To test this for u I went to Germany, Spain and Norway. LGTM!

@PrestonN PrestonN merged commit c2c5555 into FreeTubeApp:v0.17.0-RC Jun 15, 2022
@github-actions github-actions bot removed the PR: waiting for review For PRs that are complete, tested, and ready for review label Jun 15, 2022
@absidue absidue deleted the fix-gdpr-cookie branch June 15, 2022 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants