[dev] Allow more locales to be used by FreeTube#2322
Merged
PrestonN merged 1 commit intoFreeTubeApp:developmentfrom Jul 8, 2022
Merged
[dev] Allow more locales to be used by FreeTube#2322PrestonN merged 1 commit intoFreeTubeApp:developmentfrom
PrestonN merged 1 commit intoFreeTubeApp:developmentfrom
Conversation
ChunkyProgrammer
added
the
PR: waiting for review
efb4f5ff-1298-471a-8973-3d47447115dc
previously approved these changes
Jun 19, 2022
efb4f5ff-1298-471a-8973-3d47447115dc
dismissed
their stale review
forgot to check Basque/Euskera
efb4f5ff-1298-471a-8973-3d47447115dc
added
PR: changes requested
and removed
PR: waiting for review
Member
Author
|
@efb4f5ff-1298-471a-8973-3d47447115dc are you having issues on this branch too? |
ChunkyProgrammer
added
PR: waiting for review
efb4f5ff-1298-471a-8973-3d47447115dc
approved these changes
Jun 19, 2022
efb4f5ff-1298-471a-8973-3d47447115dc
requested review from
PikachuEXE and
absidue
absidue
approved these changes
Jun 20, 2022
PikachuEXE
reviewed
Jun 21, 2022
Member
PikachuEXE
left a comment
PikachuEXE
left a comment
There was a problem hiding this comment.
Is it possible to put those locales in more lines?
My brain hurts reading that long line...
Member
@PikachuEXE i guess thats a no. So could u pretty please use your ⚡️ to approve |
PikachuEXE
approved these changes
Jul 8, 2022
Member
PikachuEXE
left a comment
PikachuEXE
left a comment
There was a problem hiding this comment.
Long horizontal lines sucks...
github-actions
bot
removed
the
PR: waiting for review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[dev] Allow more locales to be used by FreeTube
Pull Request Type
Please select what type of pull request this is:
Related issue
I noticed a lot of changes recently for languages that are not currently displayed in the FreeTube app
Description
This PR allows the following locales to be selected:
ca (català/catalan), es_AR, et (Eesti/Estonian), eu (euskera/basque), ko (한국인/ korean), lt (lietuvių/lithuanian)
Testing (for code that is not small enough to be easily understandable)
Has this pull request been tested?
Please describe shortly how you tested it and whether there are any ramifications remaining.
I tested by changing my locale to the languages that were added.
Desktop (please complete the following information):
Additional context
Tested on dev branch with latest locale changes (Basque in particular got a lot of updates not in the RC branch so it won't appear to be translated as much on that branch)