Utils+Everywhere: Add a start offset tolerance for the external player#2326
Merged
PrestonN merged 1 commit intov0.17.0-RCfrom Jun 19, 2022
Merged
Conversation
If a current video is practically over or the value in the history's watch progress is almost the same as the length of the video, it's safe to deduce that if the external player button is clicked, the user is most likely just rewatching the video, making no sense to pass a start offset to it
PikachuEXE
previously approved these changes
Jun 17, 2022
PikachuEXE
requested review from
ChunkyProgrammer,
absidue and
efb4f5ff-1298-471a-8973-3d47447115dc
absidue
added
the
PR: waiting for review
efb4f5ff-1298-471a-8973-3d47447115dc
previously approved these changes
Jun 19, 2022
auto-merge was automatically disabled
June 19, 2022 18:41
Pull request was closed
github-actions
bot
removed
the
PR: waiting for review
efb4f5ff-1298-471a-8973-3d47447115dc
added
the
PR: waiting for review
efb4f5ff-1298-471a-8973-3d47447115dc
changed the base branch from
v0.17.0-RC
to
development
efb4f5ff-1298-471a-8973-3d47447115dc
dismissed stale reviews from absidue and PikachuEXE
The base branch was changed.
efb4f5ff-1298-471a-8973-3d47447115dc
changed the base branch from
development
to
v0.17.0-RC
absidue
approved these changes
Jun 19, 2022
efb4f5ff-1298-471a-8973-3d47447115dc
approved these changes
Jun 19, 2022
github-actions
bot
removed
the
PR: waiting for review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Type
Description
RC version of #2325