Fixes search suggestion issues with arrow keys#2371
Merged
PrestonN merged 3 commits intoFreeTubeApp:v0.17.0-RCfrom Jul 9, 2022
Merged
Fixes search suggestion issues with arrow keys#2371PrestonN merged 3 commits intoFreeTubeApp:v0.17.0-RCfrom
PrestonN merged 3 commits intoFreeTubeApp:v0.17.0-RCfrom
Conversation
efb4f5ff-1298-471a-8973-3d47447115dc
approved these changes
Jul 8, 2022
GilgusMaximus
approved these changes
Jul 9, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes search suggestion issues with arrow keys (RC branch)
Pull Request Type
Related issue
closes #1741
Description
This pull request fixes the cursor moving in the search bar when the up and down arrow keys are used to navigate through the search suggestions.
It also fixes the search suggestions being updated for all keyboard events even when the value of the search bar doesn't change (e.g. left and right arrow keys). Currently the search suggestions get updated for the
inputandkeydownevents, theinputonly gets fired if the value of the field changes,keydownis fired for all keyboard events.It also replaces uses of the deprecated
event.keyCodeproperty withevent.key, this improves code readability as you don't need to go and look up which key has which code.Testing (for code that is not small enough to be easily understandable)
Desktop (please complete the following information):