Fix style issue introduced in #2398#2405
Merged
PrestonN merged 1 commit intoFreeTubeApp:v0.17.0-RCfrom Jul 27, 2022
Merged
Conversation
Member
|
Im wondering why @GilgusMaximus created the spacing in the first place? |
efb4f5ff-1298-471a-8973-3d47447115dc
added
the
PR: waiting for review
Contributor
|
Might have been an artifact from hours of playing with the css, but because it did not directly influence the display I did not notice that. |
GilgusMaximus
approved these changes
Jul 20, 2022
Member
|
So to be clear this PR should also work with the banner? |
Member
Author
I have taken screenshots for with/without banners (even 1 vs 2 banners) |
efb4f5ff-1298-471a-8973-3d47447115dc
approved these changes
Jul 21, 2022
Member
efb4f5ff-1298-471a-8973-3d47447115dc
left a comment
efb4f5ff-1298-471a-8973-3d47447115dc
left a comment
There was a problem hiding this comment.
LGTM!
sorry didnt see the screenshots
ChunkyProgrammer
approved these changes
Jul 27, 2022
Member
ChunkyProgrammer
left a comment
ChunkyProgrammer
left a comment
There was a problem hiding this comment.
Hopefully this is the last pr related to the banner for a while lol
github-actions
bot
removed
the
PR: waiting for review
Member
|
I think we need another pr for dev branch |
1 task
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Type
Please select what type of pull request this is:
Related issue
Fix style issue introduced in #2398
Description
margin-topwith 60px seems way too much even for narrow windows not to mention wide windowsScreenshots (if appropriate)
There are 2 window size variants tested (according to affected stylesheet's media queires)
> 680px
<= 680px
Testing (for code that is not small enough to be easily understandable)
Has this pull request been tested?
Please describe shortly how you tested it and whether there are any ramifications remaining.
Desktop (please complete the following information):
Additional context
PR for
developmentto be created once this is reviewed (too lazy to make changes on 2 branches for every request change)