Fix scrolling through the download dropdown#2425
Merged
PrestonN merged 2 commits intoFreeTubeApp:v0.17.0-RCfrom Jul 31, 2022
Merged
Fix scrolling through the download dropdown#2425PrestonN merged 2 commits intoFreeTubeApp:v0.17.0-RCfrom
PrestonN merged 2 commits intoFreeTubeApp:v0.17.0-RCfrom
Conversation
absidue
added
the
PR: waiting for review
absidue
requested review from
ChunkyProgrammer,
GilgusMaximus,
PikachuEXE and
efb4f5ff-1298-471a-8973-3d47447115dc
efb4f5ff-1298-471a-8973-3d47447115dc
requested changes
Jul 31, 2022
Member
efb4f5ff-1298-471a-8973-3d47447115dc
left a comment
efb4f5ff-1298-471a-8973-3d47447115dc
left a comment
There was a problem hiding this comment.
see #2426 (review)
efb4f5ff-1298-471a-8973-3d47447115dc
added
PR: changes requested
and removed
PR: waiting for review
efb4f5ff-1298-471a-8973-3d47447115dc
approved these changes
Jul 31, 2022
efb4f5ff-1298-471a-8973-3d47447115dc
added
PR: waiting for review
ChunkyProgrammer
approved these changes
Jul 31, 2022
github-actions
bot
removed
the
PR: waiting for review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix scrolling through the download dropdown (RC branch)
Pull Request Type
Related issue
works around issues introduced in #2284
Description
This pull request fixes the issue with not being able to scroll through the download dropdown. It toggles the sticky css position on the video info section when the downloads menu is open. It also includes some extra code to make the toggling feel seemless.
Testing (for code that is not small enough to be easily understandable)
I tested this PR both on wide and narrow screens and was able to scroll though the download dropdown without an issues.
Desktop (please complete the following information):