Fix the localised description containing broken URLs#2572
Merged
PrestonN merged 2 commits intoFreeTubeApp:developmentfrom Sep 19, 2022
Merged
Fix the localised description containing broken URLs#2572PrestonN merged 2 commits intoFreeTubeApp:developmentfrom
PrestonN merged 2 commits intoFreeTubeApp:developmentfrom
Conversation
absidue
added
the
PR: waiting for review
absidue
requested review from
ChunkyProgrammer,
PikachuEXE and
efb4f5ff-1298-471a-8973-3d47447115dc
PikachuEXE
previously approved these changes
Sep 13, 2022
Member
PikachuEXE
left a comment
PikachuEXE
left a comment
There was a problem hiding this comment.
Tested locally with
https://www.youtube.com/watch?v=zcchDu7KoYs
Member
Author
|
Added a fix for hashtags in the title into this PR as well. |
PikachuEXE
approved these changes
Sep 17, 2022
efb4f5ff-1298-471a-8973-3d47447115dc
approved these changes
Sep 18, 2022
Member
|
@ChunkyProgrammer we need your power |
github-actions
bot
removed
the
PR: waiting for review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix the localised description containing broken URLs
Pull Request Type
Related issue
Follow up to #2535
Closes #2578
Description
This pull request fixes the truncated links in the localised video description, making them valid URLs so that
autolinkercan properly link them.Screenshots
Before:
After:
Testing
https://www.youtube.com/watch?v=zcchDu7KoYs
This video's description has a bunch of tricky things like timestamps, links to other videos, the special URL
http://www.youtube.com/approachingnirvanaand the lttstore link has utm tracking parameters.Desktop (please complete the following information):