Skip to content

Fix shift enter on top nav search input does not open search in a new window#3113

Merged
FreeTubeBot merged 1 commit intoFreeTubeApp:developmentfrom
PikachuEXE:fix/shift-enter-new-window-search
Jan 24, 2023
Merged

Fix shift enter on top nav search input does not open search in a new window#3113
FreeTubeBot merged 1 commit intoFreeTubeApp:developmentfrom
PikachuEXE:fix/shift-enter-new-window-search

Conversation

@PikachuEXE
Copy link
Member

Pull Request Type

  • Bugfix
  • Feature Implementation
  • Documentation
  • Other

Related issue

Feature implemented in #2427
Broken by #2943

Description

Feature broken due to missing event when calling handleClick

Screenshots

N/A

Testing

  • Enter text into top nav search input
  • Shift enter
  • Confirm search opened in new window

Desktop

  • OS: MacOS
  • OS Version: 12.6.2
  • FreeTube version: 0145a04

Additional context

Shift click still works without this fix

@github-actions github-actions bot added the PR: waiting for review For PRs that are complete, tested, and ready for review label Jan 24, 2023
@FreeTubeBot FreeTubeBot enabled auto-merge (squash) January 24, 2023 04:09
@FreeTubeBot FreeTubeBot merged commit 38b856f into FreeTubeApp:development Jan 24, 2023
@github-actions github-actions bot removed the PR: waiting for review For PRs that are complete, tested, and ready for review label Jan 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants