Fix channel handle URLs with tabs#3241
Merged
FreeTubeBot merged 1 commit intoFreeTubeApp:developmentfrom Mar 3, 2023
Merged
Conversation
absidue
requested review from
ChunkyProgrammer,
PikachuEXE and
efb4f5ff-1298-471a-8973-3d47447115dc
github-actions
bot
added
the
PR: waiting for review
ChunkyProgrammer
approved these changes
Mar 2, 2023
PikachuEXE
approved these changes
Mar 3, 2023
efb4f5ff-1298-471a-8973-3d47447115dc
approved these changes
Mar 3, 2023
github-actions
bot
removed
the
PR: waiting for review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix channel handle URLs with tabs
Pull Request Type
Related issue
found in #1568 (review)
Description
The current code doesn't read the tab from the channel URL if the URL has a handle in it.
e.g. https://www.youtube.com/@mkbhd/playlists
Testing
https://www.youtube.com/@mkbhd/about
https://www.youtube.com/@mkbhd/playlists
check that these still work:
https://www.youtube.com/@mkbhd
https://www.youtube.com/@mkbhd/videos
Desktop