Hide Most Popular menu entry if the selected backend is not Invidious and backend fallback is disabled#3339
Merged
FreeTubeBot merged 1 commit intoFreeTubeApp:developmentfrom Mar 22, 2023
Conversation
… and backend fallback is disabled
absidue
requested review from
ChunkyProgrammer,
PikachuEXE and
efb4f5ff-1298-471a-8973-3d47447115dc
github-actions
bot
added
the
PR: waiting for review
efb4f5ff-1298-471a-8973-3d47447115dc
approved these changes
Mar 21, 2023
PikachuEXE
approved these changes
Mar 22, 2023
ChunkyProgrammer
approved these changes
Mar 22, 2023
github-actions
bot
removed
the
PR: waiting for review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hide Most Popular menu entry if the selected backend is not Invidious and backend fallback is disabled
Pull Request Type
Related issue
closes #3325
Description
Currently the
Most Popularmenu entry is only hidden if theHide popular videosdistraction free setting is enabled, that behaviour differs from the navigation bar, which also hides it if the local API is selected in combination with backend fallback being disabled.Testing
Change the backend and backend fallback settings. Ensure that the
Most Popularentry in theNavigatemenu is hidden when the local API is selected in combination with backend fallback being disabled and that it's visible otherwise.Desktop