Update watch page to stop at end of playlist (when loop disabled) without countdown#3362
Merged
FreeTubeBot merged 3 commits intoFreeTubeApp:developmentfrom Apr 27, 2023
Conversation
efb4f5ff-1298-471a-8973-3d47447115dc
previously approved these changes
Apr 1, 2023
5 tasks
absidue
reviewed
Apr 18, 2023
efb4f5ff-1298-471a-8973-3d47447115dc
previously approved these changes
Apr 19, 2023
Member
Contributor
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
Co-authored-by: absidue <48293849+absidue@users.noreply.github.com>
12bfa58 to
b48c3af
Compare
Contributor
|
Conflicts have been resolved. A maintainer will review the pull request shortly. |
Member
Author
|
You have spotted a 3 year old bug o_0 Fixed & rebased due to merge conflict https://github.com/FreeTubeApp/FreeTube/blame/f94d8a9df257ba3ac78feddc038a3ebebebe4c08/src/renderer/components/watch-video-playlist/watch-video-playlist.js#L208-L210 |
Member
efb4f5ff-1298-471a-8973-3d47447115dc
approved these changes
Apr 25, 2023
ChunkyProgrammer
approved these changes
Apr 25, 2023
absidue
approved these changes
Apr 27, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Pull Request Type
Related issue
N/A
Description
Found it weird to see countdown at the end of playlist before seeing "The playlist has ended"
This PR makes it shows that message immediately without countdown
Countdown unchanged when loop enabled/playlist not ended
Screenshots
Testing
Matrix A x B x C
A
B
C
Only these combinations should show "The playlist has ended" immediately
Desktop
Additional context