Fix video comment external link parsing for local API#3448
Merged
FreeTubeBot merged 1 commit intoFreeTubeApp:developmentfrom Apr 26, 2023
Merged
Conversation
PikachuEXE
requested review from
ChunkyProgrammer,
absidue and
efb4f5ff-1298-471a-8973-3d47447115dc
github-actions
bot
added
the
PR: waiting for review
Member
|
Cant find the comment on the YT side, are u sure this is the right url? |
Member
Author
Member
|
@efb4f5ff-1298-471a-8973-3d47447115dc try sorting by newest if it doesn't show up |
absidue
approved these changes
Apr 21, 2023
efb4f5ff-1298-471a-8973-3d47447115dc
approved these changes
Apr 25, 2023
Member
efb4f5ff-1298-471a-8973-3d47447115dc
left a comment
efb4f5ff-1298-471a-8973-3d47447115dc
left a comment
There was a problem hiding this comment.
Found it, LGTM!
ChunkyProgrammer
approved these changes
Apr 26, 2023
github-actions
bot
removed
the
PR: waiting for review
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Type
Related issue
Description
There is an error when parsing a "run" (part of a comment) from local API
This PR fixes it
Screenshots
Comment to be parsed
Actual
runobject from Youtubei.jsTesting
Desktop
Additional context