Ensure FT stay "running in background" on MacOS after all window closed#3526
Merged
FreeTubeBot merged 1 commit intoFreeTubeApp:developmentfrom May 11, 2023
Merged
Conversation
PikachuEXE
requested review from
ChunkyProgrammer,
MarmadileManteater,
absidue and
efb4f5ff-1298-471a-8973-3d47447115dc
github-actions
bot
added
the
PR: waiting for review
5 tasks
ChunkyProgrammer
approved these changes
May 11, 2023
absidue
approved these changes
May 11, 2023
Member
|
@QAQDE Check out the screen recording in the PR body is this the behavior u want to see? |
absidue
approved these changes
May 11, 2023
Yes, it now looks completely fine. Thanks |
efb4f5ff-1298-471a-8973-3d47447115dc
approved these changes
May 11, 2023
github-actions
bot
removed
the
PR: waiting for review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Type
Related issue
Fixes #2934
Description
I think FT already stay "running in background" on MacOS after closing all windows, but only once (due to calling
onceinstead ofonin main app code)This PR simply changes
oncetoonforwindow-all-closedeventScreenshots
Done in dev mode, so you can see the dock icon is Electron, and part of dev tool as FT window
Screen.Recording.2023-05-11.at.09.14.30.mov
Testing
Desktop
Additional context