Add basic support for PotPlayer, MPC-HC, MPC-BE#3798
Add basic support for PotPlayer, MPC-HC, MPC-BE#3798FreeTubeBot merged 5 commits intoFreeTubeApp:developmentfrom
Conversation
PikachuEXE
left a comment
There was a problem hiding this comment.
e9fae08
Moves entries around
Also the indent alignment is inconsistent with other entries
Head branch was pushed to by a user without write access
|
Thanks, fixed the indents. As for the reordering, that was intentional so the list would be alphabetical. It just makes more sense to me. Do you have any objections to that? |
|
It's harder to review the diff If we want the display order to be updated it should be done in code not in data (with limited no. of entries) |
Head branch was pushed to by a user without write access
|
Well, I've had a look around the relevant code, but I'm afraid that's above my pay grade. Until someone else feels the need to tackle that, here's the unsorted list back :) |
PikachuEXE
left a comment
There was a problem hiding this comment.
Code looks fine but I will wait for #3797 to be merged first
|
Thanks for your contribution @trostboot. If u want to address more external player issues u could take a look at #1975 |
Add basic support for PotPlayer, MPC-HC, MPC-BE
Pull Request Type
Related issue
closes #3614
Description
This PR adds basic external player functionality for PotPlayer, MPC-HC and MPC-BE.
It also sorts the list alphabetically, because UX.
Note that MPC-HC requires yt-dlp or similar to be present.
It will also fail to properly play back videos with a startOffset if the resolution is > 1080p (audio will play, video will be black). Unfortunately the default limit (View > Options > Advanced > YDLMaxHeight) MPC-HC ships with is 1440p.
Feedback desired on whether startOffset should stay enabled given the current state.
Note that MPC-BE requires yt-dlp or similar to be present and enabled in order to parse playlists.
Note that both MPC-HC and MPC-BE require #3797 to fix playback from within playlists.
Screenshots
Testing
Desktop
Additional context