Include hide comment photos setting#3939
Include hide comment photos setting#3939FreeTubeBot merged 6 commits intoFreeTubeApp:developmentfrom
Conversation
github-actions
bot
added
the
PR: waiting for review
|
Not sure what the other think about this but IMO if the creator of the video places a comment its maybe better to see their profile picture for more visibility I know their name is highlighted but that could be easily overlooked IMO |
@robjob1938 Thoughts on this? I would personally agree with @efb4f5ff-1298-471a-8973-3d47447115dc, in that you would already be being presented with the video creator's thumbnail photo in the video info section anyway. |
Head branch was pushed to by a user without write access
|
Updated the UI, leaving the previous version above for reference Replaces this
with
|
|
The work @Benjababe did looks perfect, thank you very much! |
PikachuEXE
left a comment
PikachuEXE
left a comment
There was a problem hiding this comment.
Tested with https://youtu.be/0cTpTMl8kFY
There was a problem hiding this comment.
This one can be removed like stated in #3938 (comment)
static/locales/en-US.yaml
Outdated
| Hide Active Subscriptions: Hide Active Subscriptions | ||
| Hide Video Description: Hide Video Description | ||
| Hide Comments: Hide Comments | ||
| Hide Comment Photos: Hide Comment Photos |
There was a problem hiding this comment.
I'm not sure about this naming. Maybe something like Hide Profile Pictures in Comments but i like to hear the other team members on this
There was a problem hiding this comment.
"Hide Comment Profile Pictures" or "Hide Comment Author Thumbnails" would be my top two suggestions.
There was a problem hiding this comment.
"Hide Profile Pictures in Comments"
"Hide Comment Profile Pictures" looks more confusing ("Comment Profile Pictures" is too much to parse
There was a problem hiding this comment.
You've changed my mind, that does sound better.
efb4f5ff-1298-471a-8973-3d47447115dc
left a comment
efb4f5ff-1298-471a-8973-3d47447115dc
left a comment
There was a problem hiding this comment.
Opinions needed
Head branch was pushed to by a user without write access
Head branch was pushed to by a user without write access
efb4f5ff-1298-471a-8973-3d47447115dc
requested review from
ChunkyProgrammer,
PikachuEXE,
absidue and
kommunarr
github-actions
bot
removed
the
PR: waiting for review
6 participants
Include hide comment photos setting
Pull Request Type
Related issue
Closes #3919
Description
Adds toggle switch to Settings>Distraction Free Settings>Watch Page>Hide Comment Photos
Essentially hides profile pictures in comments, replaces it with the default background color of the FreeTube profile on the top right (assuming styling is subject to change) and the first character of the commenter's username.
Livestream chat isn't affected, not sure to touch it or not.
Screenshots
Replaces this
with
Testing
Looked through a couple of videos and it seemed fine
Desktop
Additional context
Same query with this PR about the i18n stuff.