Skip to content

Make constants imported from @fortawesome/free-solid-svg-icons ordered by name again #3958

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
FreeTubeBot merged 2 commits into from
Aug 29, 2023
Merged

Make constants imported from @fortawesome/free-solid-svg-icons ordered by name again #3958

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b1c5d53
$ Make constants imported from @fortawesome/free-solid-svg-icons orde…
PikachuEXE Aug 28, 2023
1f5ab19
~ Add code comment about constant list ordering
PikachuEXE Aug 29, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions src/renderer/main.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,8 @@ import router from './router/index'
import store from './store/index'
import i18n from './i18n/index'
import { library } from '@fortawesome/fontawesome-svg-core'
// Please keep the list of constants sorted by name
// to avoid code conflict and duplicate entries
import {
faAngleDown,
faArrowDown,
Expand All @@ -26,6 +28,8 @@ import {
faExchangeAlt,
faExclamationCircle,
faExternalLinkAlt,
faEye,
faEyeSlash,
faFileDownload,
faFileVideo,
faFilter,
Expand Down Expand Up @@ -57,8 +61,6 @@ import {
faTimes,
faTimesCircle,
faUsers,
faEye,
faEyeSlash,
} from '@fortawesome/free-solid-svg-icons'
import {
faBitcoin,
Expand All @@ -72,6 +74,8 @@ Vue.config.devtools = process.env.NODE_ENV === 'development'
Vue.config.performance = process.env.NODE_ENV === 'development'
Vue.config.productionTip = process.env.NODE_ENV === 'development'

// Please keep the list of constants sorted by name
// to avoid code conflict and duplicate entries
library.add(
// solid icons
faAngleDown,
Expand All @@ -94,6 +98,8 @@ library.add(
faExchangeAlt,
faExclamationCircle,
faExternalLinkAlt,
faEye,
faEyeSlash,
faFileDownload,
faFileVideo,
faFilter,
Expand Down Expand Up @@ -125,8 +131,6 @@ library.add(
faTimes,
faTimesCircle,
faUsers,
faEye,
faEyeSlash,

// brand icons
faGithub,
Expand Down