Subscriptions: Add community tab by ChunkyProgrammer · Pull Request #3973 · FreeTubeApp/FreeTube

ChunkyProgrammer · 2023-08-29T16:13:46Z

Subscriptions: Add community tab

Pull Request Type

Feature Implementation

Related issue

Description

If you have less than 125 subscriptions in your profile then a tab is added on the subscription page for community posts.

Screenshots

Testing

(Local + Invidious)

view subscription page (less than 125 subscriptions)
see community tab
click on community tab
see posts ordered by date
disable community tab is Distraction Free Settings
view subscription page
dont see community tab
have over 125 subscriptions
view subscription page
dont see community tab

Desktop

OS: windows
OS Version: 10
FreeTube version: 0.19.0

src/renderer/views/Subscriptions/Subscriptions.js

static/locales/en-US.yaml

src/renderer/components/ft-community-post/ft-community-post.vue

github-actions · 2023-08-30T00:22:39Z

This pull request has conflicts, please resolve those before we can evaluate the pull request.

github-actions · 2023-08-30T00:23:44Z

Conflicts have been resolved. A maintainer will review the pull request shortly.

PikachuEXE · 2023-08-30T01:44:52Z

IV API = useless error messages

PikachuEXE · 2023-08-30T01:48:47Z

Changed this.activeSubscriptionList.length < 125 to 5 so I don't have to subscribe that many channels
But tab still visible

disable community tab in Distraction Free Settings works though

github-actions · 2023-08-31T15:21:11Z

This pull request has conflicts, please resolve those before we can evaluate the pull request.

github-actions · 2023-09-01T13:11:34Z

Conflicts have been resolved. A maintainer will review the pull request shortly.

src/renderer/helpers/api/invidious.js

github-actions · 2023-09-20T12:03:07Z

This pull request has conflicts, please resolve those before we can evaluate the pull request.

github-actions · 2023-09-20T19:25:38Z

Conflicts have been resolved. A maintainer will review the pull request shortly.

PikachuEXE

Assuming nothing much change since last reviewed

github-actions · 2023-09-22T10:05:55Z

This pull request has conflicts, please resolve those before we can evaluate the pull request.

github-actions · 2023-09-22T15:35:11Z

Conflicts have been resolved. A maintainer will review the pull request shortly.

ChunkyProgrammer added 2 commits August 26, 2023 08:42

Add subscription community tab

a6b5988

fix up community tab

446688a

FreeTubeBot enabled auto-merge (squash) August 29, 2023 16:14

github-actions bot added the PR: waiting for review For PRs that are complete, tested, and ready for review label Aug 29, 2023

absidue reviewed Aug 29, 2023

View reviewed changes

src/renderer/views/Subscriptions/Subscriptions.js Outdated Show resolved Hide resolved

static/locales/en-US.yaml Show resolved Hide resolved

src/renderer/components/ft-community-post/ft-community-post.vue Outdated Show resolved Hide resolved

ChunkyProgrammer added 2 commits August 29, 2023 17:21

simplify if statement

91893ec

use global.community for all references to community

5b4475d

github-actions bot added PR: merge conflicts / rebase needed and removed PR: waiting for review For PRs that are complete, tested, and ready for review labels Aug 30, 2023

Merge branch 'development' into add-subscription-community

0c985c1

github-actions bot removed the PR: merge conflicts / rebase needed label Aug 30, 2023

ChunkyProgrammer requested a review from absidue August 30, 2023 00:23

dont show community when useRss is set

05bbc12

ChunkyProgrammer requested review from PikachuEXE, efb4f5ff-1298-471a-8973-3d47447115dc and kommunarr August 30, 2023 00:25

ChunkyProgrammer added the PR: waiting for review For PRs that are complete, tested, and ready for review label Aug 30, 2023

check visibleTabs for showing the community tab

fe35848

github-actions bot added PR: merge conflicts / rebase needed and removed PR: waiting for review For PRs that are complete, tested, and ready for review labels Aug 31, 2023

Merge branch 'development' into add-subscription-community

5ef6961

github-actions bot removed the PR: merge conflicts / rebase needed label Sep 1, 2023

ChunkyProgrammer added the PR: waiting for review For PRs that are complete, tested, and ready for review label Sep 1, 2023

PikachuEXE previously approved these changes Sep 2, 2023

View reviewed changes

absidue reviewed Sep 18, 2023

View reviewed changes

src/renderer/helpers/api/invidious.js Show resolved Hide resolved

add links to related issues

29df968

ChunkyProgrammer added the PR: waiting for review For PRs that are complete, tested, and ready for review label Sep 18, 2023

ChunkyProgrammer requested a review from absidue September 18, 2023 18:13

github-actions bot added PR: merge conflicts / rebase needed and removed PR: waiting for review For PRs that are complete, tested, and ready for review labels Sep 20, 2023

Merge branch 'development' into add-subscription-community

7d8c803

ChunkyProgrammer added the PR: waiting for review For PRs that are complete, tested, and ready for review label Sep 20, 2023

github-actions bot removed the PR: merge conflicts / rebase needed label Sep 20, 2023

PikachuEXE previously approved these changes Sep 20, 2023

View reviewed changes

absidue previously approved these changes Sep 21, 2023

View reviewed changes

github-actions bot added PR: merge conflicts / rebase needed and removed PR: waiting for review For PRs that are complete, tested, and ready for review labels Sep 22, 2023

Merge branch 'development' into add-subscription-community

cd916e2

ChunkyProgrammer dismissed stale reviews from absidue and PikachuEXE via cd916e2 September 22, 2023 15:34

github-actions bot removed the PR: merge conflicts / rebase needed label Sep 22, 2023

absidue approved these changes Sep 22, 2023

View reviewed changes

ChunkyProgrammer requested a review from PikachuEXE September 22, 2023 15:52

ChunkyProgrammer added the PR: waiting for review For PRs that are complete, tested, and ready for review label Sep 22, 2023

PikachuEXE approved these changes Sep 22, 2023

View reviewed changes

kommunarr approved these changes Sep 23, 2023

View reviewed changes

FreeTubeBot merged commit 47ef3e5 into FreeTubeApp:development Sep 23, 2023

github-actions bot removed the PR: waiting for review For PRs that are complete, tested, and ready for review label Sep 23, 2023

PikachuEXE mentioned this pull request Sep 23, 2023

Fix in subscription view, restoring last tab is bugged when visible tabs do not include tab to be restored #4064

Merged

4 tasks

ChunkyProgrammer deleted the add-subscription-community branch September 23, 2023 13:55

Conversation

ChunkyProgrammer commented Aug 29, 2023

Subscriptions: Add community tab

Pull Request Type

Related issue

Description

Screenshots

Testing

Desktop

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Aug 30, 2023

Uh oh!

github-actions bot commented Aug 30, 2023

Uh oh!

PikachuEXE commented Aug 30, 2023

Uh oh!

PikachuEXE commented Aug 30, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Aug 31, 2023

Uh oh!

github-actions bot commented Sep 1, 2023

Uh oh!

Uh oh!

github-actions bot commented Sep 20, 2023

Uh oh!

github-actions bot commented Sep 20, 2023

Uh oh!

PikachuEXE left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Sep 22, 2023

Uh oh!

github-actions bot commented Sep 22, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

PikachuEXE commented Aug 30, 2023 •

edited

Loading