Profile settings UX improvements

[kommunarr]

Profile settings UX improvements

Pull Request Type

• Feature Implementation

Related issue

closes #1860

Description

1. Translates 'All Channels` profile name for all users
2. Disables custom names for the All Channels profile
3. Combines ProfileSettings and ProfileEdit into one route and page
4. Reorders Subscriptions List and Other Channels sections to be above Edit Profile section for an existing profile
5. Adds a handful of labels
6. Modifies Edit/Create Profile card UX
7. Fixes minor pre-existing bug of the Profile Filter selected count not resetting that occurred with these replication steps:
   i. Go to Profile Edit for a given profile
   ii. Under "Other Channels," select 1 or more channels
   iii. Change the profile in the Profile Filter
   iv. Encounter bug (count & selection are/were bugged)
8. Fixes minor pre-existing bug of the Profile Filter resetting to All Channels after selecting "Add Selected to Profile" with another profile
9. Fixes minor bug of the selected count for either "Other Channels" or "Subscription List" bugging when a channel is added / removed while another channel is already selected in the list.

Video

simplescreenrecorder-2023-09-20_19.22.02-2023-11-20_00.46.13.mp4

Testing

Note: I do all of this in the video.

• Test creating a new profile
• Test "All Channels" is properly localized in all instances (Profile Selector dropdown, Profile Selector active profile change toast, Profile Settings, Profile Edit -> "Other Channels" profile filter, Profile Edit for "All Channels" -> Edit Name, Profile Edit for "All Channels" -> Make Default Profile toast) by testing with a non-English locale
• Test that bug in line item 7 is resolved using the replications steps listed
• Test that bugs in line items 8 and 9 is resolved using the replication steps listed

Desktop

• OS: OpenSUSE Tumbleweed
• OS Version: 2023xxxx
• FreeTube version: 0.19.1

[github-actions]

This pull request has conflicts, please resolve those before we can evaluate the pull request.

[github-actions]

Conflicts have been resolved. A maintainer will review the pull request shortly.

[absidue]

Haven't tested the code yet so this is just a small code review.

[PikachuEXE]

Change the profile in the Profile Filter

Do you mean Profile Manager? (i.e. Changing profile there would properly cause Other Channels content to be updated/reset. If so it's works fine. If not please explain further.

Have trouble understanding (9)

Found a potential style bug (but maybe not) (also might not be caused by this PR, dunno)
Text in select option is centered, I think most select option text in FT is left aligned

[kommunarr]

Change the profile in the Profile Filter

Do you mean Profile Manager?

I'm referring to this:

Have trouble understanding (9)

See 1:00 - 1:10 in the video.

Found a potential style bug (but maybe not) (also might not be caused by this PR, dunno) Text in select option is centered, I think most select option text in FT is left aligned

Good catch. It was an old overwrite of the base styling that wasn't very good.

[PikachuEXE]

7-9 passed

The style can be fixed by removing

:deep(.select) {
  text-align-last: center;
}

Otherwise seems fine

[kommunarr]

@PikachuEXE a little late to the party

[PikachuEXE]