Add dearrow support for thumbnails#4520
Merged
FreeTubeBot merged 5 commits intoFreeTubeApp:developmentfrom Jan 15, 2024
Merged
Conversation
github-actions
bot
added
the
PR: waiting for review
Collaborator
|
Is missing the tooltip label, otherwise is looking good behavior-wise. |
Member
|
All Thumbnail Preferences are overwritten except for Blur. Q: Should we even overwrite thumbnail preference
|
ChunkyProgrammer
requested review from
PikachuEXE,
absidue,
efb4f5ff-1298-471a-8973-3d47447115dc and
kommunarr
PikachuEXE
reviewed
Jan 14, 2024
| }, | ||
|
|
||
| displayDuration: function () { | ||
| if (this.useDeArrowTitles && (this.duration === '' || this.duration === '0:00') && this.deArrowCache?.videoDuration) { |
Member
There was a problem hiding this comment.
- In the "Subscription Settings" turn on "Fetch Feeds from RSS".
- Subscribe to a channel that has dearrow titles e.g. https://www.youtube.com/@MrBeast
- On the subscription page any unwatched videos from that channel should now have durations shown (for watched videos the duration comes from the watch history).
absidue
reviewed
Jan 14, 2024
Member
absidue
left a comment
absidue
left a comment
There was a problem hiding this comment.
The code works, just a few small suggestions concerning performance and an outdated code comment.
absidue
added
PR: changes requested
and removed
PR: waiting for review
Co-authored-by: absidue <48293849+absidue@users.noreply.github.com>
absidue
approved these changes
Jan 14, 2024
absidue
added
PR: waiting for review
PikachuEXE
approved these changes
Jan 15, 2024
Member
PikachuEXE
left a comment
PikachuEXE
left a comment
There was a problem hiding this comment.
Tested fetch sub via RSS + duration
kommunarr
approved these changes
Jan 15, 2024
github-actions
bot
removed
the
PR: waiting for review
PikachuEXE
added a commit
to PikachuEXE/FreeTube
that referenced
this pull request
Jan 15, 2024
…mark * development: (53 commits) Add dearrow support for thumbnails (FreeTubeApp#4520) Translated using Weblate (French) Fix hardware acceleration flag for Linux (FreeTubeApp#4532) Translated using Weblate (Bengali) Translated using Weblate (Czech) Translated using Weblate (Hungarian) Translated using Weblate (Turkish) Translated using Weblate (Spanish) Translated using Weblate (Arabic) Translated using Weblate (Italian) Translated using Weblate (Polish) Translated using Weblate (Russian) Translated using Weblate (French) Translated using Weblate (Chinese (Simplified)) Add toggle to suppress sending additional args to external players (FreeTubeApp#4515) Translated using Weblate (English (United Kingdom)) Translated using Weblate (Italian) Translated using Weblate (French) Translated using Weblate (Finnish) Translated using Weblate (Polish) ... # Conflicts: # src/renderer/store/modules/settings.js
PikachuEXE
added a commit
to PikachuEXE/FreeTube
that referenced
this pull request
Jan 15, 2024
…m-builds/current * feature/consistent-sharable-video-url-local: (30 commits) * Update places generating sharable YT video URLs to always return prefix https://youtu.be/ Translated using Weblate (Chinese (Traditional)) Translated using Weblate (Chinese (Simplified)) Add dearrow support for thumbnails (FreeTubeApp#4520) Translated using Weblate (French) Fix hardware acceleration flag for Linux (FreeTubeApp#4532) Translated using Weblate (Bengali) Translated using Weblate (Czech) Translated using Weblate (Hungarian) Translated using Weblate (Turkish) Translated using Weblate (Spanish) Translated using Weblate (Arabic) Translated using Weblate (Italian) Translated using Weblate (Polish) Translated using Weblate (Russian) Translated using Weblate (French) Translated using Weblate (Chinese (Simplified)) Add toggle to suppress sending additional args to external players (FreeTubeApp#4515) Translated using Weblate (English (United Kingdom)) Translated using Weblate (Italian) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add dearrow support for thumbnails
Pull Request Type
Related issue
closes #4146
Description
This PR allows for using DeArrow for thumbnails. This PR also stores the duration of a video in the dearrow cache if available and will fallback to the dearrow duration for shorts, etc.
Screenshots
DeArrowed Screenshot:
Non DeArrowed Screenshot:
Testing
test 1
test 2
test 3
Desktop