Support YouTube using PageHeader on user channels not just auto-generated ones by absidue · Pull Request #4543 · FreeTubeApp/FreeTube

absidue · 2024-01-14T14:05:55Z

Support YouTube using PageHeader on user channels not just auto-generated ones

Pull Request Type

Bugfix
Feature Implementation

Related issues

Description

This pull request fixes the TypeError: Cannot read properties of undefined (reading 'name') error messages that you may have seen poping up on the subscriptions page and on the channel pages. There are other places in FreeTube that make requests to the channel page, however I decided not to change anything there yet, as that would cause conflicts with #4340.

YouTube has an A/B test going on to use the PageHeader node on user channels, previously it was only used on system channels like @gaming. This pull request adds support for that to FreeTube.

Screenshots

Testing

In src/renderer/helpers/api/local.js add visitor_data: 'CgtwUmJqXzhJdVFCSijM_oStBg%3D%3D', to the InnerTube.create call in the createInnertube function e.g. between line 46 and 47.

Test various user channels e.g. https://youtube.com/@YouTube and then also the system ones https://youtube.com/@gaming and https://youtube.com/@live to make sure that the new logic didn't break them (they are empty apart from the header, the banner being missing is expected too as they don't have one on YouTube).

--- a/src/renderer/helpers/api/local.js
+++ b/src/renderer/helpers/api/local.js
@@ -44,6 +44,7 @@ async function createInnertube(options = { withPlayer: false, location: undefine
 
   return await Innertube.create({
     retrieve_player: !!options.withPlayer,
+    visitor_data: 'CgtwUmJqXzhJdVFCSijM_oStBg%3D%3D',
     location: options.location,
     enable_safety_mode: !!options.safetyMode,
     client_type: options.clientType,

Desktop

OS: Windows
OS Version: 10
FreeTube version: 0.19.1

absidue · 2024-01-14T14:06:52Z

jsconfig.json

    "target": 2.7
+  },
+  "compilerOptions": {
+    "strictNullChecks": true


This makes vscode actually show undefined and null in type definitions e.g. auto-complete and the popup that appears when you hover over functions.

PikachuEXE · 2024-01-30T00:39:27Z

Got conflict but bot not announcing?

github-actions · 2024-01-30T00:39:42Z

This pull request has conflicts, please resolve those before we can evaluate the pull request.

efb4f5ff-1298-471a-8973-3d47447115dc · 2024-01-30T04:18:47Z

is it possible to provide a build so i can daily drive this for a day or two

…ated ones

github-actions · 2024-01-30T17:29:05Z

Conflicts have been resolved. A maintainer will review the pull request shortly.

PikachuEXE · 2024-01-31T01:05:53Z

@efb4f5ff-1298-471a-8973-3d47447115dc
https://github.com/PikachuEXE/FreeTube/actions/runs/7719513038
Only got dev & this PR

absidue · 2024-01-31T17:03:23Z

@curather That's just a placebo, YouTube randomly returns the empty feed. This pull request has no change that affects the watch page, even the YouTube.js upgrade doesn't affect it.
Anyway that issue is off-topic for this pull request.

package.json

…ated ones (#4543) * Support YouTube using PageHeader on user channels not just auto-generated ones * Bump YouTube.js to 9.0.2 as requested

absidue commented Jan 14, 2024

View reviewed changes

absidue added the PR/Issue: dependent label Jan 14, 2024

absidue force-pushed the user-channel-page-header branch from 7090682 to 4b1579a Compare January 15, 2024 17:06

absidue force-pushed the user-channel-page-header branch from 4b1579a to 91e7102 Compare January 29, 2024 17:48

absidue marked this pull request as ready for review January 29, 2024 17:51

FreeTubeBot enabled auto-merge (squash) January 29, 2024 17:51

github-actions bot added PR: dependencies Pull requests that update a dependency file PR: waiting for review For PRs that are complete, tested, and ready for review labels Jan 29, 2024

absidue requested review from ChunkyProgrammer, MarmadileManteater, PikachuEXE, efb4f5ff-1298-471a-8973-3d47447115dc and kommunarr January 29, 2024 17:52

absidue removed the PR/Issue: dependent label Jan 29, 2024

github-actions bot removed the PR: waiting for review For PRs that are complete, tested, and ready for review label Jan 30, 2024

github-actions bot added the PR: merge conflicts / rebase needed label Jan 30, 2024

Support YouTube using PageHeader on user channels not just auto-gener…

bad92f0

…ated ones

absidue force-pushed the user-channel-page-header branch from 91e7102 to bad92f0 Compare January 30, 2024 17:28

github-actions bot removed the PR: merge conflicts / rebase needed label Jan 30, 2024

absidue added the PR: waiting for review For PRs that are complete, tested, and ready for review label Jan 30, 2024

This comment was marked as off-topic.

Sign in to view

efb4f5ff-1298-471a-8973-3d47447115dc previously approved these changes Feb 1, 2024

View reviewed changes

PikachuEXE previously approved these changes Feb 1, 2024

View reviewed changes

PikachuEXE reviewed Feb 1, 2024

View reviewed changes

package.json Outdated Show resolved Hide resolved

Bump YouTube.js to 9.0.2 as requested

a70067e

absidue dismissed stale reviews from PikachuEXE and efb4f5ff-1298-471a-8973-3d47447115dc via a70067e February 4, 2024 17:53

efb4f5ff-1298-471a-8973-3d47447115dc approved these changes Feb 4, 2024

View reviewed changes

efb4f5ff-1298-471a-8973-3d47447115dc requested a review from PikachuEXE February 4, 2024 21:04

PikachuEXE approved these changes Feb 4, 2024

View reviewed changes

absidue mentioned this pull request Feb 5, 2024

Bump youtubei.js from 8.2.0 to 9.0.2 #4636

Closed

ChunkyProgrammer approved these changes Feb 9, 2024

View reviewed changes

FreeTubeBot merged commit 30248d6 into FreeTubeApp:development Feb 9, 2024

github-actions bot removed the PR: waiting for review For PRs that are complete, tested, and ready for review label Feb 9, 2024

absidue deleted the user-channel-page-header branch February 9, 2024 16:45

absidue mentioned this pull request Feb 12, 2024

Fix the Invidious DASH manifest generation #4672

Merged

1 task

absidue added a commit that referenced this pull request Feb 23, 2024

Support YouTube using PageHeader on user channels not just auto-gener…

f1db161

…ated ones (#4543) * Support YouTube using PageHeader on user channels not just auto-generated ones * Bump YouTube.js to 9.0.2 as requested

absidue mentioned this pull request Mar 25, 2024

Fix extracting the subscriber count from channel PageHeader nodes #4804

Merged

1 task

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Support YouTube using PageHeader on user channels not just auto-generated ones#4543

Support YouTube using PageHeader on user channels not just auto-generated ones#4543
FreeTubeBot merged 2 commits intoFreeTubeApp:developmentfrom
absidue:user-channel-page-header

absidue commented Jan 14, 2024 •

edited

Loading

Uh oh!

absidue Jan 14, 2024

Uh oh!

PikachuEXE commented Jan 30, 2024

Uh oh!

github-actions bot commented Jan 30, 2024

Uh oh!

efb4f5ff-1298-471a-8973-3d47447115dc commented Jan 30, 2024

Uh oh!

github-actions bot commented Jan 30, 2024

Uh oh!

PikachuEXE commented Jan 31, 2024

Uh oh!

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

absidue commented Jan 31, 2024 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Conversation

absidue commented Jan 14, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Support YouTube using PageHeader on user channels not just auto-generated ones

Pull Request Type

Related issues

Description

Screenshots

Testing

Desktop

Uh oh!

absidue Jan 14, 2024

Choose a reason for hiding this comment

Uh oh!

PikachuEXE commented Jan 30, 2024

Uh oh!

github-actions bot commented Jan 30, 2024

Uh oh!

efb4f5ff-1298-471a-8973-3d47447115dc commented Jan 30, 2024

Uh oh!

github-actions bot commented Jan 30, 2024

Uh oh!

PikachuEXE commented Jan 31, 2024

Uh oh!

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

absidue commented Jan 31, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

absidue commented Jan 14, 2024 •

edited

Loading

absidue commented Jan 31, 2024 •

edited

Loading