Move usingElectron from computed into data#4810
Merged
FreeTubeBot merged 1 commit intoFreeTubeApp:developmentfrom Mar 27, 2024
Merged
Move usingElectron from computed into data#4810FreeTubeBot merged 1 commit intoFreeTubeApp:developmentfrom
FreeTubeBot merged 1 commit intoFreeTubeApp:developmentfrom
Conversation
absidue
added
the
PR: low priority
absidue
requested review from
ChunkyProgrammer,
MarmadileManteater,
PikachuEXE and
efb4f5ff-1298-471a-8973-3d47447115dc
github-actions
bot
added
the
PR: waiting for review
PikachuEXE
approved these changes
Mar 26, 2024
Member
efb4f5ff-1298-471a-8973-3d47447115dc
left a comment
efb4f5ff-1298-471a-8973-3d47447115dc
left a comment
There was a problem hiding this comment.
External Player Settings isnt listed when i ran yarn run dev:web
Member
Author
That is expected and mentioned in the testing section of the pull request (we can't run command line commands from inside a web browser). |
efb4f5ff-1298-471a-8973-3d47447115dc
approved these changes
Mar 26, 2024
ChunkyProgrammer
approved these changes
Mar 27, 2024
github-actions
bot
removed
the
PR: waiting for review
PikachuEXE
added a commit
to PikachuEXE/FreeTube
that referenced
this pull request
Apr 2, 2024
* development: (72 commits) Add support for CommentViews in video comments (FreeTubeApp#4806) Add support for LockupViews on the channel podcasts tab (FreeTubeApp#4767) Bump youtubei.js from 9.1.0 to 9.2.0 (FreeTubeApp#4836) Bump swiper from 11.0.7 to 11.1.0 (FreeTubeApp#4837) Bump the stylelint group with 1 update (FreeTubeApp#4835) Bump the eslint group with 1 update (FreeTubeApp#4834) Bump electron from 29.1.5 to 29.1.6 (FreeTubeApp#4838) Translated using Weblate (Estonian) Fix v-observe-visibility error when playlist items are updated (FreeTubeApp#4774) Fix extracting the subscriber count from channel PageHeader nodes (FreeTubeApp#4804) Translated using Weblate (Portuguese) Create empty subscriptions cache objects directly instead of cloning (FreeTubeApp#4814) Parse compact numbers without using floating point numbers to avoid accuracy issues (FreeTubeApp#4817) Fix the left arrow key not working on the first button in prompts (FreeTubeApp#4816) Fix the web build's manifest.json file getting included in the electron build (FreeTubeApp#4815) Move usingElectron from computed into data (FreeTubeApp#4810) Stop setting node modules path now that we bundle the modules (FreeTubeApp#4809) Translated using Weblate (Bulgarian) Bump express from 4.18.1 to 4.19.2 (FreeTubeApp#4812) Translated using Weblate (Portuguese (Brazil)) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move usingElectron from computed into data
Pull Request Type
Description
As that value is set at build time and never changes at runtime, we don't need any of the benefits of a computed property (avoiding doing costly operations more often than necessary), so it's better suited in
data.Testing
Check that the external player settings still show up in the Electron build (
yarn run dev), check that they are still correctly hidden in the web build (yarn run dev:web).Desktop