Add more options to default playback rate menu

[msagr]

Add more options to default playback rate menu

Pull Request Type

• Bugfix
• Feature Implementation
• Documentation
• Other

Related issue

closes #4564

Description

This pull request makes the playback rate menu smoother by providing users with more playback options at intervals of 0.05 from 0.25 to 3

Desktop

• OS: Ubuntu
• OS Version: 22.04
• FreeTube version: 0.20.0

[efb4f5ff-1298-471a-8973-3d47447115dc]

Hi @msagr thank you for taking time to address this issue. Unfortunately you have interpreted the request incorrect.

OP meant that the default playback speed should be adjusted properly.

So when video playback rate interval is set to 0.1 the default playback speed should also be configurable in steps of 0.1 instead of being unchanged and showing steps of 0.25

screen-20240405-224750.mp4

[msagr]

Thanks a lot, I have tried to fix it in this PR. Please let me know if any other issue remains in this.

[absidue]

Please undo the "Add confirmation pop-up when unsubscribing", as that is unrelated to what you were originally aiming for with this pull request.

[msagr]

Oh, I mistakenly opened it in same PR. Should I make a separate commit removing the code i just committed or there is some other way of undoing it I am not aware of in my limited knowledge.

[PikachuEXE]

• Checkout the branch (people normally use a separate branch for a PR instead all into one branch but in this case development
• Create a branch to save the unrelated changes if you want to save them
• Reset branch development hard to commit make slider precise as per playback speed
• Force push

[msagr]

@efb4f5ff-1298-471a-8973-3d47447115dc type error resolved.

[PikachuEXE]

The playback rate seems broken when interval set to 0.1/0.5 (coz 0.25 is minimum value and now 1.0 cannot be selected)

[msagr]

Thanks @PikachuEXE for pointing out the issue. I have tried to resolve it. Please let me know if any other bug remains in it.

[efb4f5ff-1298-471a-8973-3d47447115dc]

1. Set Video Playback Rate Interval to 0.1
2. Try to set Default Playback Rate to 0.1
3. Observe that Default Playback Rate only goes to a minimum of 0.3

VirtualBoxVM_7a78VAy0o9.mp4

[msagr]

Done

[efb4f5ff-1298-471a-8973-3d47447115dc]

Works like a charm, Thanks for the PR!

[Massimo-B]

What are the current possible values for Video Playback Rate Interval? The smallest is 0.1 here, I'm on v0.21.3 Beta.
Beside the already added 0.1 from #1238 it would be nice to also add 0.05 and 0.01. Using https://github.com/TeamNewPipe/NewPipe, with well cut content, I usually use 1.05 or 1.07 depending on the producer and content.

They use a different UI which would avoid having a setting like that. They have a dialog with slider and step-down/step-up buttons, additionally buttons for setting the step-width like 1% 5% 10% 25% 100%: