Fix user playlist reverse button behavior

[kommunarr]

Fix user playlist reverse button behavior

Pull Request Type

• Bugfix

Related issue

None

Description

Co-author: @absidue (identified where issue was occurring)

User playlists that are reversed revert to their normal ordering after the next video is loaded. This PR fixes that by making our parseUserPlaylist function maintain a reversed order. It also removes a watch property that @absidue identified as not relevant.

Testing

• Reverse a playlist and then navigate to another video in the playlist. See that the playlist is still reversed

Desktop

• OS: OpenSUSE
• OS Version: TW

Additional context

CC: @PikachuEXE if we're missing a purpose for this watch property. Its removal isn't strictly required for this fix.

Note: we're doing x = x.toReversed() instead x.reverse() to avoid a warning for mutating Vuex data.

[PikachuEXE]

Not related but found that no progress bar displayed when playlist reversed (remote + local)
Expected?

[PikachuEXE]

About removal of playlistItemId in watch
Seems fine for playlist changes I made when playing the playlist
Should be fine to remove

[kommunarr]

Not related but found that no progress bar displayed when playlist reversed (remote + local)
Expected?

Apparently? I'll have to check to see if there's a rationale.

FreeTube/src/renderer/components/watch-video-playlist/watch-video-playlist.vue

Lines 43 to 49 in 372bc1b

	<progress
	v-if="!shuffleEnabled && !reversePlaylist"
	id="playlistProgressBar"
	class="playlistProgressBar"
	:value="currentVideoIndexOneBased"
	:max="playlistVideoCount"
	/>

Edit: To pull out the 2-year old receipts, this is what you had to say about it:

What about only showing this when the order is "ascending" (with shuffling disabled)
We can figure out if that's useful for "reverse order" (I don't even know that exists)