Fixes opening an external player on the watch page passes user playlist#5263
Merged
FreeTubeBot merged 2 commits intoFreeTubeApp:developmentfrom Jun 16, 2024
Merged
Conversation
efb4f5ff-1298-471a-8973-3d47447115dc
previously approved these changes
Jun 13, 2024
kommunarr
previously approved these changes
Jun 15, 2024
PikachuEXE
reviewed
Jun 15, 2024
20677aa
Member
Author
|
I've made the parameter required now. |
kommunarr
approved these changes
Jun 16, 2024
efb4f5ff-1298-471a-8973-3d47447115dc
approved these changes
Jun 16, 2024
PikachuEXE
approved these changes
Jun 16, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes opening an external player on the watch page passes user playlist
Pull Request Type
Related issue
#5188 (it's a discussion so the close keyword doesn't work)
Description
The code to open an external player in the watch-video-info component was checking
this.inUserPlaylistto decide whether or not to pass the playlist information to the external player. Unfortunately thoughthis.inUserPlaylistdidn't exist, so it was passing playlist information to the external player. This pull request adds the missinginUserPlaylistproperty.Screenshots
Before:

After:

Testing
openInExternalPlayerinsrc/renderer/store/modules/utils.jsNone(you don't actually have to have the player installed, because of the code snippet above)Desktop