Use streams from the iOS client to workaround playback issues by absidue · Pull Request #5472 · FreeTubeApp/FreeTube

absidue · 2024-07-25T17:43:25Z

Use streams from the iOS client to workaround playback issues

Pull Request Type

Bugfix

Related issue

closes #5453
closes #5370

Description

As YouTube is currently introducing various changes to the WEB client, which cause the random 403s and the random No valid URL to decipher errors. This pull request aims to solve both of those issues, by using the DASH streams from the iOS client instead. Age-restricted videos are still expected to have the random 403s problem, as the client we use to bypass the forced login, has the same problems as the WEB client. I've had to add overrides in a few places to get it to actually work, such as the User-Agent, however those overrides should only affect iOS requests.

Unfortunately the iOS client doesn't have the opus audio streams.

Testing

Please test this pull request thoroughly with various different videos (e.g. normal, live streams, age-restricted, music).

Age-restricted videos are still expected to have the random 403s problem.

Desktop

OS: Windows
OS Version: 10
FreeTube version: 0.21.2

PikachuEXE

Testing it daily~

src/renderer/helpers/api/local.js

PikachuEXE · 2024-07-26T00:32:15Z

Livestream: Lofi https://youtu.be/_uMuuHk_KkQ
Age-restricted videos: #5343
Music: ???

PikachuEXE · 2024-07-26T10:27:36Z

What Music video is the testing referring to?

absidue · 2024-07-26T10:31:30Z

Music videos have stronger restrictions on them, e.g. geo restrictions and on the website you need to do extra steps to get them to play. So any music video should work, the main thing is just to check that it plays.

PikachuEXE

No random 403 so far in my custom build (with shaka
Let me test this until Tuesday

PikachuEXE · 2024-07-29T07:54:41Z

I am testing this with shaka together to play long playlists on MacOS & Windows
On both OS I notice sometimes 10 seconds are skipped on random video only happens per > 10 videos

Screen.Recording.2024-07-29.at.15.52.10.mov

See some SponsorBlock errors but not sure if related

Update 1: SponsorBlock not related
I just got 2nd time happening on 0:39 again (another video)

Update 2: Got another one 0:59 > 1:09 on windows

absidue · 2024-07-29T17:29:48Z

Okay that definitely shouldn't be happening, it's also interesting that it is random, I wonder if it has anything to do with this pull request using random app versions and iOS versions.

PikachuEXE · 2024-07-30T00:56:45Z

Built a custom build printing client version and iOS version
Let's see what would be printed when the issue occurs again (will need at least 3-5 times)

1st:
0:39 > 0:49
client 19.24.2
ios 17.5.1

ArthurKun21 · 2024-07-31T03:21:36Z

also using Pikachu's shaka build

https://youtu.be/J-4XwZGGn_o

I did skip from 0:58 -> 1:10

PikachuEXE · 2024-07-31T08:14:16Z

I can't reproduce with that video yet
But it happens really rarely and I am using another custom build (with a bit more debugging printing client & iOS versions

I only got 1 jump so far

PikachuEXE

No jump detected for the last day
Not such a big issue to prevent merging

efb4f5ff-1298-471a-8973-3d47447115dc · 2024-08-01T11:36:17Z

Retested, havent seen any weird skips

PikachuEXE · 2024-08-01T12:48:16Z

Last time it requires 5x videos to 1-3 skips
If I find more skips and/or can reproduce it consistently I will update here but not serious enough to block the merge

…beApp#5472) * Use streams from the iOS client to workaround playback issues * Fix for unplayable videos * Hoist version arrays and introduce a randomArrayItem helper

…o workaround playback issues (#5508) * ^ Update youtubei.js * Use streams from the iOS client to workaround playback issues (#5472) * Use streams from the iOS client to workaround playback issues * Fix for unplayable videos * Hoist version arrays and introduce a randomArrayItem helper --------- Co-authored-by: absidue <48293849+absidue@users.noreply.github.com>

…ctions - ^Update youtubei.js - Use streams from the iOS client to workaround playback issues (FreeTubeApp#5472) - Allow user agent spoofing for usage of iOS client

efb4f5ff-1298-471a-8973-3d47447115dc · 2024-08-03T07:25:12Z

It just dawned on me that the weird skips arent maybe related to this PR but to FT in general.

Users of adblockers reported on reddit that they have seeing black screens for 5-15sec and it might be related to sever side ad injection

Could that explain the random skips?

absidue · 2024-08-03T07:33:57Z

That definitely would make sense and would also explain why it doesn't happen very often yet, because YouTube hasn't fully rolled them out yet.

* development: Bump version number to v0.21.3 Bump sass-loader from 14.2.1 to 16.0.0 (FreeTubeApp#5495) ^ Update youtubei.js (FreeTubeApp#5507) Use streams from the iOS client to workaround playback issues (FreeTubeApp#5472)

Use streams from the iOS client to workaround playback issues

70849d7

absidue requested review from ChunkyProgrammer, MarmadileManteater, PikachuEXE, efb4f5ff-1298-471a-8973-3d47447115dc and kommunarr July 25, 2024 17:43

github-actions bot added the PR: waiting for review For PRs that are complete, tested, and ready for review label Jul 25, 2024

FreeTubeBot enabled auto-merge (squash) July 25, 2024 17:43

Fix for unplayable videos

31a2f8e

PikachuEXE reviewed Jul 25, 2024

View reviewed changes

src/renderer/helpers/api/local.js Outdated Show resolved Hide resolved

Hoist version arrays and introduce a randomArrayItem helper

7c8d1dc

This comment was marked as off-topic.

Sign in to view

efb4f5ff-1298-471a-8973-3d47447115dc added PR: changes requested and removed PR: waiting for review For PRs that are complete, tested, and ready for review labels Jul 26, 2024

This comment was marked as off-topic.

Sign in to view

efb4f5ff-1298-471a-8973-3d47447115dc approved these changes Jul 26, 2024

View reviewed changes

efb4f5ff-1298-471a-8973-3d47447115dc added PR: waiting for review For PRs that are complete, tested, and ready for review and removed PR: changes requested labels Jul 26, 2024

PikachuEXE reviewed Jul 26, 2024

View reviewed changes

efb4f5ff-1298-471a-8973-3d47447115dc mentioned this pull request Aug 1, 2024

Update YouTube.js 10.3.0 #5507

Merged

4 tasks

PikachuEXE approved these changes Aug 1, 2024

View reviewed changes

ChunkyProgrammer approved these changes Aug 1, 2024

View reviewed changes

FreeTubeBot merged commit 3a245ec into FreeTubeApp:development Aug 1, 2024

github-actions bot removed the PR: waiting for review For PRs that are complete, tested, and ready for review label Aug 1, 2024

absidue deleted the ios-workaround branch August 1, 2024 12:49

PikachuEXE mentioned this pull request Aug 1, 2024

(Master) Update YouTube.js 10.3.0 & Use streams from the iOS client to workaround playback issues #5508

Merged

4 tasks

Conversation

absidue commented Jul 25, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Use streams from the iOS client to workaround playback issues

Pull Request Type

Related issue

Description

Testing

Desktop

Uh oh!

PikachuEXE left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

PikachuEXE commented Jul 26, 2024

Uh oh!

PikachuEXE commented Jul 26, 2024

Uh oh!

absidue commented Jul 26, 2024

Uh oh!

This comment was marked as off-topic.

Uh oh!

This comment was marked as off-topic.

This comment was marked as off-topic.

PikachuEXE left a comment

Choose a reason for hiding this comment

Uh oh!

PikachuEXE commented Jul 29, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

absidue commented Jul 29, 2024

Uh oh!

PikachuEXE commented Jul 30, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ArthurKun21 commented Jul 31, 2024

Uh oh!

PikachuEXE commented Jul 31, 2024

Uh oh!

PikachuEXE left a comment

Choose a reason for hiding this comment

Uh oh!

efb4f5ff-1298-471a-8973-3d47447115dc commented Aug 1, 2024

Uh oh!

PikachuEXE commented Aug 1, 2024

Uh oh!

efb4f5ff-1298-471a-8973-3d47447115dc commented Aug 3, 2024

Uh oh!

absidue commented Aug 3, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

absidue commented Jul 25, 2024 •

edited

Loading

PikachuEXE commented Jul 29, 2024 •

edited

Loading

PikachuEXE commented Jul 30, 2024 •

edited

Loading