Support authentication with the Basic scheme for Invidious instances#5569
Merged
FreeTubeBot merged 2 commits intoFreeTubeApp:developmentfrom Aug 23, 2024
Merged
Conversation
absidue
requested review from
ChunkyProgrammer,
MarmadileManteater,
PikachuEXE,
efb4f5ff-1298-471a-8973-3d47447115dc and
kommunarr
github-actions
bot
added
the
PR: waiting for review
PikachuEXE
previously approved these changes
Aug 15, 2024
Member
|
I have only checked (2) not (1) coz no idea which instance got |
Member
|
This line needs to be updated to have
Once this is fixed, I think it should be good to merge. I'll do a bit more testing but so far everything else seems to be working (I'm using Basic Http Authentication for my testing) |
ChunkyProgrammer
previously approved these changes
Aug 16, 2024
PikachuEXE
previously approved these changes
Aug 18, 2024
github-actions
bot
added
PR: merge conflicts / rebase needed
and removed
PR: waiting for review
Contributor
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
Member
efb4f5ff-1298-471a-8973-3d47447115dc
left a comment
efb4f5ff-1298-471a-8973-3d47447115dc
left a comment
There was a problem hiding this comment.
LGTM, Approving after rebased!
1 task
absidue
dismissed stale reviews from PikachuEXE and ChunkyProgrammer
via
60d2e17
absidue
force-pushed
the
invidious-basic-auth
branch
from
29c5b51 to
60d2e17
Compare
Contributor
|
Conflicts have been resolved. A maintainer will review the pull request shortly. |
ChunkyProgrammer
approved these changes
Aug 20, 2024
ChunkyProgrammer
requested review from
PikachuEXE and
efb4f5ff-1298-471a-8973-3d47447115dc
PikachuEXE
approved these changes
Aug 21, 2024
efb4f5ff-1298-471a-8973-3d47447115dc
approved these changes
Aug 23, 2024
PikachuEXE
added a commit
to PikachuEXE/FreeTube
that referenced
this pull request
Aug 26, 2024
* shaka-migration: Use the HLS manifests for live streams Update shaka-player to version 4.10.11 Translated using Weblate (Japanese) Translated using Weblate (Japanese) Support authentication with the Basic scheme for Invidious instances (FreeTubeApp#5569) Translated using Weblate (Romanian) Translated using Weblate (Romanian)
3 tasks
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Support authentication with the Basic scheme for Invidious instances
Pull Request Type
Related issue
closes #686
Description
This pull request adds support for using Invidious instances that use the Basic authentication scheme
username:password@example.com. Since the original issue was opened a lot had changed and more than just the thumbnails were broken, so this pull request adds support everywhere from the API requests, to the RSS feeds, as well asthe audio and legacy formats and of course the images.Outside of Electron with the changes in this pull request I only expect the API requests and the RSS feeds to work.
This will likely cause a bunch of conflicts with the shaka PR but I'll clean those up after this is merged and do the neccessary changes to get it working with the shaka stuff too.
Testing
username:password@example.com@TheFrenchGhosty If you want to try/test this pull request before it is merged, here's a build that you can use so that you don't have to setup the development environment: https://github.com/absidue/FreeTube/actions/runs/10394591062 (due to GitHub restrictions you'll have to be logged in to download it)
Desktop