Add Playlist Sort By Video Duration#5627
Add Playlist Sort By Video Duration#5627FreeTubeBot merged 16 commits intoFreeTubeApp:developmentfrom Hoverth:development
Conversation
Head branch was pushed to by a user without write access
Head branch was pushed to by a user without write access
Head branch was pushed to by a user without write access
Head branch was pushed to by a user without write access
|
Odd. Now it is not displaying the toast message at all |
Head branch was pushed to by a user without write access
|
Alright that should fix the issue. |
Head branch was pushed to by a user without write access
|
Works fine so far except I think the notice should be shown also when changing sort order in single playlist view (unless already shown
(B)
|
Head branch was pushed to by a user without write access
|
7143e62 moves the call to when the playlist items are sorted, so if you load a playlist and then change the sorting, it'll still show. This means (A) and most of (B) are handled. I'm not terribly sure how to make it only fire once though. Thoughts? |
Head branch was pushed to by a user without write access
|
Alright, I've given single-firing only a shot, and also tweaked the time to be only 5 seconds, as 10 seemed a little long to me |
PikachuEXE
left a comment
There was a problem hiding this comment.
Maybe just loop it once?
Test locally before committing that change~
Co-authored-by: PikachuEXE <git@pikachuexe.net>
Head branch was pushed to by a user without write access
Head branch was pushed to by a user without write access
It does feel a little bit faster, but that could just be placebo. Either way, it should be more efficient now. |
Head branch was pushed to by a user without write access
Head branch was pushed to by a user without write access
absidue
left a comment
There was a problem hiding this comment.
Not a fan of cloning the entire playlist, but as I can't come up with a better solution at the moment and everything else about this pull request is good, I'll approve.
Add Playlist Sort By Video Duration
Pull Request Type
Related issue
Closes: #5268
Description
Closes issue #5268 and PR #5423. It works off what @creotove put in their PR, but also includes a small notification if there is a video in the playlist that does not have a time attached to it.