fix cmd+m shortcut to minimize the window on macos and not mute the video#5829
Merged
FreeTubeBot merged 1 commit intoFreeTubeApp:developmentfrom Oct 7, 2024
jacopo-degattis:fix/macos-mute-shortcut
Merged
fix cmd+m shortcut to minimize the window on macos and not mute the video#5829FreeTubeBot merged 1 commit intoFreeTubeApp:developmentfrom jacopo-degattis:fix/macos-mute-shortcut
FreeTubeBot merged 1 commit intoFreeTubeApp:developmentfrom
jacopo-degattis:fix/macos-mute-shortcut
Conversation
github-actions
bot
added
the
PR: waiting for review
PikachuEXE
approved these changes
Oct 7, 2024
PikachuEXE
requested review from
ChunkyProgrammer,
absidue and
efb4f5ff-1298-471a-8973-3d47447115dc
ChunkyProgrammer
approved these changes
Oct 7, 2024
absidue
approved these changes
Oct 7, 2024
github-actions
bot
removed
the
PR: waiting for review
PikachuEXE
added a commit
to PikachuEXE/FreeTube
that referenced
this pull request
Oct 7, 2024
* development: (55 commits) Translated using Weblate (Russian) Translated using Weblate (Japanese) fix cmd+m shortcut to minimize the window on macos and not mute the video (FreeTubeApp#5828) (FreeTubeApp#5829) Update dependabot.yml to add new eslint packages into the eslint group (FreeTubeApp#5837) Bump the babel group with 4 updates (FreeTubeApp#5831) Bump globals from 15.9.0 to 15.10.0 (FreeTubeApp#5835) Bump lefthook from 1.7.17 to 1.7.18 (FreeTubeApp#5836) Bump the eslint group with 2 updates (FreeTubeApp#5832) Bump @eslint/js from 9.11.1 to 9.12.0 (FreeTubeApp#5833) Bump @eslint/compat from 1.1.1 to 1.2.0 (FreeTubeApp#5834) Translated using Weblate (Belarusian) Translated using Weblate (Hebrew) Translated using Weblate (Chinese (Traditional Han script)) Turn `vue/no-useless-template-attributes` eslint rule back on (FreeTubeApp#5830) Translated using Weblate (Serbian) Translated using Weblate (Belarusian) Translated using Weblate (Belarusian) Translated using Weblate (Belarusian) Upgrade eslint 8 > 9 (FreeTubeApp#5777) Translated using Weblate (Belarusian) ...
PikachuEXE
added a commit
to PikachuEXE/FreeTube
that referenced
this pull request
Oct 10, 2024
* development: (59 commits) Translated using Weblate (Belarusian) Translated using Weblate (Belarusian) Translated using Weblate (Belarusian) Enable Belarusian locale (FreeTubeApp#5841) Translated using Weblate (Russian) Translated using Weblate (Japanese) fix cmd+m shortcut to minimize the window on macos and not mute the video (FreeTubeApp#5828) (FreeTubeApp#5829) Update dependabot.yml to add new eslint packages into the eslint group (FreeTubeApp#5837) Bump the babel group with 4 updates (FreeTubeApp#5831) Bump globals from 15.9.0 to 15.10.0 (FreeTubeApp#5835) Bump lefthook from 1.7.17 to 1.7.18 (FreeTubeApp#5836) Bump the eslint group with 2 updates (FreeTubeApp#5832) Bump @eslint/js from 9.11.1 to 9.12.0 (FreeTubeApp#5833) Bump @eslint/compat from 1.1.1 to 1.2.0 (FreeTubeApp#5834) Translated using Weblate (Belarusian) Translated using Weblate (Hebrew) Translated using Weblate (Chinese (Traditional Han script)) Turn `vue/no-useless-template-attributes` eslint rule back on (FreeTubeApp#5830) Translated using Weblate (Serbian) Translated using Weblate (Belarusian) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cmd+M shortcut now minimize the window on macos and doesn't mute the video anymore.
Pull Request Type
Related issue
closes #5828
Description
Before this pull request when the shortcut
cmd + mwas pressed on macOS the video got muted even though on macOS that shortcut is intended to minimize the window.What I did is to add a check on whether the
metaKeywas pressed or not and act accordingly.Now when the
metaKeyis pressed with themkey the window minimize and when only themkey is pressed the video get muted.Screenshots
Testing
Desktop
Additional context