Add keyboard shortcuts to titles#5857
Merged
FreeTubeBot merged 18 commits intoFreeTubeApp:developmentfrom Dec 2, 2024
Merged
Conversation
github-actions
bot
added
the
PR: waiting for review
kommunarr
force-pushed
the
feat/add-shortcut-labels
branch
from
24b233d to
0d3882e
Compare
PikachuEXE
reviewed
Oct 14, 2024
Member
|
Label for captions |
Collaborator
Author
|
Another good catch; I wasn't testing with a video that had a captions option. Just fixed the issue and added logic preventing label modification if the Shaka localization key does not exist. Also note that this specific Captions label will be the only one with another parenthetical present. This is fine IMO.
|
kommunarr
force-pushed
the
feat/add-shortcut-labels
branch
from
ad59178 to
6202ff7
Compare
…has no matching value
kommunarr
force-pushed
the
feat/add-shortcut-labels
branch
from
6202ff7 to
7c379e2
Compare
Member
efb4f5ff-1298-471a-8973-3d47447115dc
left a comment
efb4f5ff-1298-471a-8973-3d47447115dc
left a comment
There was a problem hiding this comment.
Pressing c doesnt enable/disable captions
Collaborator
Author
|
Added localization of shortcuts & multi-key shortcuts and caught a dangling instance of the wrong constant name for |
kommunarr
requested review from
ChunkyProgrammer and
efb4f5ff-1298-471a-8973-3d47447115dc
Member
|
Question: Navigating to the History tab and Settings tab also got shortcuts. Is there a reason those weren't added? |
Collaborator
Author
|
@efb4f5ff-1298-471a-8973-3d47447115dc I specifically added the shortcuts with corresponding button labels. The closest equivalent to those would be the corresponding side nav options, which I suppose would work. I can add those as well. |
kommunarr
force-pushed
the
feat/add-shortcut-labels
branch
from
b934703 to
6f8d212
Compare
efb4f5ff-1298-471a-8973-3d47447115dc
previously approved these changes
Oct 14, 2024
PikachuEXE
previously approved these changes
Oct 15, 2024
Member
PikachuEXE
left a comment
PikachuEXE
left a comment
There was a problem hiding this comment.
Tested video player, sidebar, top nav button labels, refresh button
Only on MacOS though
Contributor
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
Member
correct |
…at/add-shortcut-labels
…ube into feat/add-shortcut-labels
Contributor
|
Conflicts have been resolved. A maintainer will review the pull request shortly. |
PikachuEXE
reviewed
Nov 24, 2024
kommunarr
force-pushed
the
feat/add-shortcut-labels
branch
from
8410df1 to
304fa82
Compare
PikachuEXE
previously approved these changes
Nov 24, 2024
kommunarr
force-pushed
the
feat/add-shortcut-labels
branch
from
84deb9e to
cb7f395
Compare
kommunarr
force-pushed
the
feat/add-shortcut-labels
branch
from
cb7f395 to
532fcc7
Compare
PikachuEXE
approved these changes
Nov 27, 2024
ChunkyProgrammer
added
the
PR: waiting for review
absidue
approved these changes
Dec 1, 2024
efb4f5ff-1298-471a-8973-3d47447115dc
approved these changes
Dec 2, 2024
github-actions
bot
removed
the
PR: waiting for review
Soham456
pushed a commit
to Soham456/FreeTube
that referenced
this pull request
Dec 5, 2024
* Update title for custom FreeTube button labels with keyboard shortcuts * Add keyboard shortcut to unmodified Shaka control labels * Replace in-code use of available shortcuts with the corresponding constants * Add explanatory comments * Fix captions constant name * Prevent creating new shortcut localization if Shaka localization key has no matching value * Add util functions to localize special keys * Replace more video player shortcut usage in code with corresponding constants * Add labels for History and Settings app shortcuts, and update variable naming * Display 'Option' instead of 'Alt' for Mac users * Use Mac icons in keyboard shortcuts for Macs * Update Mac arrow icon choice * Update KeyboardShortcuts constant organization in preparation for keyboard shorcut modal * Adjust nameSpan._textContent to be set to same value as aria-label * Add code comment explaining shakaControlKeysToShortcuts * Move changes from deleted Popular.js to Popular.vue
jlvivero
pushed a commit
to jlvivero/FreeTube
that referenced
this pull request
Dec 7, 2024
* Update title for custom FreeTube button labels with keyboard shortcuts * Add keyboard shortcut to unmodified Shaka control labels * Replace in-code use of available shortcuts with the corresponding constants * Add explanatory comments * Fix captions constant name * Prevent creating new shortcut localization if Shaka localization key has no matching value * Add util functions to localize special keys * Replace more video player shortcut usage in code with corresponding constants * Add labels for History and Settings app shortcuts, and update variable naming * Display 'Option' instead of 'Alt' for Mac users * Use Mac icons in keyboard shortcuts for Macs * Update Mac arrow icon choice * Update KeyboardShortcuts constant organization in preparation for keyboard shorcut modal * Adjust nameSpan._textContent to be set to same value as aria-label * Add code comment explaining shakaControlKeysToShortcuts * Move changes from deleted Popular.js to Popular.vue
SuperAKWA
pushed a commit
to SuperAKWA/FreeTube
that referenced
this pull request
Jan 24, 2025
* Update title for custom FreeTube button labels with keyboard shortcuts * Add keyboard shortcut to unmodified Shaka control labels * Replace in-code use of available shortcuts with the corresponding constants * Add explanatory comments * Fix captions constant name * Prevent creating new shortcut localization if Shaka localization key has no matching value * Add util functions to localize special keys * Replace more video player shortcut usage in code with corresponding constants * Add labels for History and Settings app shortcuts, and update variable naming * Display 'Option' instead of 'Alt' for Mac users * Use Mac icons in keyboard shortcuts for Macs * Update Mac arrow icon choice * Update KeyboardShortcuts constant organization in preparation for keyboard shorcut modal * Adjust nameSpan._textContent to be set to same value as aria-label * Add code comment explaining shakaControlKeysToShortcuts * Move changes from deleted Popular.js to Popular.vue
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add keyboard shortcuts to titles
Pull Request Type
Related issue
closes #1587
Description
Mute (m)Screenshots
Testing
Full screen (f)/Exit full screen (f)). See the official list of shortcuts for reference.Desktop
Additional context
The addition of the new constants should help make enhancements like #251 easier in the future.