Minor performance improvements to the Hashtag view#5927
Merged
FreeTubeBot merged 1 commit intoFreeTubeApp:developmentfrom Oct 24, 2024
Merged
Minor performance improvements to the Hashtag view#5927FreeTubeBot merged 1 commit intoFreeTubeApp:developmentfrom
FreeTubeBot merged 1 commit intoFreeTubeApp:developmentfrom
Conversation
github-actions
bot
added
the
PR: waiting for review
kommunarr
approved these changes
Oct 23, 2024
PikachuEXE
approved these changes
Oct 24, 2024
efb4f5ff-1298-471a-8973-3d47447115dc
approved these changes
Oct 24, 2024
github-actions
bot
removed
the
PR: waiting for review
Soham456
pushed a commit
to Soham456/FreeTube
that referenced
this pull request
Dec 5, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Minor performance improvements to the Hashtag view
Pull Request Type
Related issue
#5825 (comment)
Description
This pull request implements two small performance improvements to the hashtag view. The first one is that we don't have to call
resetData()in the mounted hook, as at the time that the mounted hook is called all the fields still have their default values. The second one is to only watch thehashtagparam on the current route object, as that is the only property that could change while you are on the hashtag page.Testing
#shorts#asmrDesktop