Change default locale to system#6031
Merged
FreeTubeBot merged 1 commit intoFreeTubeApp:developmentfrom Oct 31, 2024
Merged
Conversation
github-actions
bot
added
the
PR: waiting for review
absidue
approved these changes
Oct 30, 2024
Member
absidue
left a comment
absidue
left a comment
There was a problem hiding this comment.
We should definitely call this out as a significant change in the changelog, as English speaking users may have never changed the locale setting and might be surprised when FreeTube suddenly starts with their system locale instead.
PikachuEXE
approved these changes
Oct 31, 2024
kommunarr
approved these changes
Oct 31, 2024
github-actions
bot
removed
the
PR: waiting for review
Soham456
pushed a commit
to Soham456/FreeTube
that referenced
this pull request
Dec 5, 2024
SuperAKWA
pushed a commit
to SuperAKWA/FreeTube
that referenced
this pull request
Jan 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change default locale to system
Pull Request Type
Description
By default we should probably be using the language of the user's system if possible, otherwise we fallback to en-US. There were some issues with the system locale in the past which is why it wasn't made the default sooner but it seems to be working now.
I also updated the name of a variable to make it more clear that it's the fallback locale
Testing
Desktop